Skip to content

TST/STYLE: remove multiprocess nose flags and slight PEP fixes #15333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

TST/STYLE: remove multiprocess nose flags and slight PEP fixes #15333

wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Feb 7, 2017

@jreback jreback added Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite labels Feb 7, 2017
@jreback jreback added this to the 0.20.0 milestone Feb 7, 2017
@jreback
Copy link
Contributor Author

jreback commented Feb 7, 2017 •
edited
Loading

I ended up having to autopep8 things to remove the extra lines when I took out the multiprocessing directive. But seems to pass and all be good. Slight PEP is even on non-qa files (some aspects of them).

@jorisvandenbossche @TomAugspurger @bashtage

@jorisvandenbossche
Copy link
Member

This will not conflict with Tom's pytest PR?

@TomAugspurger
Copy link
Contributor

I just did a test rebase on top of this, and didn't have to resolve any conflicts. Haven't looked at the new diff yet though.

@jorisvandenbossche
Copy link
Member

@jreback The test files are not tested for PEP8 on travis? And would they pass now with those changes?

@jreback
Copy link
Contributor Author

jreback commented Feb 7, 2017

i am not 100% sure we are testing ALL files (that's why some things were changed)

everything passes now but let me see if i can add the other files

@jreback
Copy link
Contributor Author

jreback commented Feb 7, 2017

actually I think the slight peps are to files what we ignore flake on. so pretty innocuous.

@jreback jreback closed this in 542c916 Feb 7, 2017
@TomAugspurger TomAugspurger mentioned this pull request Feb 7, 2017
Closed
4 tasks
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@jreback @AnkurDedania
TST/STYLE: remove multiprocess nose flags and slight PEP fixes
0f10b04 
xref pandas-dev#13856 (comment)

Author: Jeff Reback <[email protected]>

Closes pandas-dev#15333 from jreback/mcs and squashes the following commits:

2edc842 [Jeff Reback] TST/STYLE: remove multiprocess nose flags and slight PEP fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Code Style Code style, linting, code_checks Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jreback @jorisvandenbossche @TomAugspurger