TST: MultiIndex Slicing maintains first level index (#12697) #15255
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Seems it was already fixed in 0.19.0 as well. Just wondering for the location of the test, we don't have a separate class/file for multi-index tests? Now it seems in one gigantic |
jorisvandenbossche
added
Testing
Current coverage is 86.32% (diff: 100%)@@ master #15255 diff @@
==========================================
Files 139 139
Lines 51149 51149
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 44156 44156
Misses 6993 6993
Partials 0 0
|
|
some tests in test_multilevel some in test_indexing prob should make a new combined one |
|
@mroeschke Thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffThe original issue appears to work correctly on master and doesn't seem to have been fixed by a PR from 0.20.0