Make Series.map() documentation a bit more verbose #15235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -2138,6 +2138,14 @@ def map(self, arg, na_action=None): | |||
| two bar | |||
| three baz | |||
|
|
|||
| >>> z | |||
There was a problem hiding this comment.
Can you add a single sentence between the examples? Like "Mapping a dictionary works similar as with a Series (mapping dict keys on index labels): "
| @@ -2138,6 +2138,14 @@ def map(self, arg, na_action=None): | |||
| two bar | |||
| three baz | |||
|
|
|||
| >>> z | |||
There was a problem hiding this comment.
Could you add a single sentence between the examples? Eg something like "Mapping a dict works similarly to mapping a Series (the dict keys are mapped on the index labels): "
|
Thanks for the quick response. I have added some text and added more code to be able to reproduce 'at home'. |
Current coverage is 86.31% (diff: 100%)@@ master #15235 diff @@
==========================================
Files 139 139
Lines 51091 51091
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 44099 44099
Misses 6992 6992
Partials 0 0
|
|
thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Author: manuels <[email protected]> Closes pandas-dev#15235 from manuels/patch-1 and squashes the following commits: c5113f2 [manuels] Make Series.map() documentation a bit more verbose
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.