-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: support MultiIndex and tuple hashing #15224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cc @mikegraham I separated this from the prior PR. yes my goal here is to effectively emulate |
@mikegraham |
3bd237f
to
157dcd2
Compare
Current coverage is 86.32% (diff: 100%)@@ master #15224 diff @@
==========================================
Files 139 139
Lines 51096 51140 +44
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 44103 44148 +45
+ Misses 6993 6992 -1
Partials 0 0
|
There were a couple memory improvements in 187573b over the commit as you cherry-picked it, I think. |
@mikegraham ahh ok, I will pick-again. thanks! |
@mikegraham ok fixed. Note that this obviously returns |
I stole the algorithm, but it's not compatible. I also iterate over the members in forward error rather than reverse...I don't think that is substantive. |
cc @mikegraham any final comments? |
We might want to do something about this behavior.
|
@mikegraham updated |
closes pandas-dev#15227 Author: Jeff Reback <[email protected]> Author: Mike Graham <mikegraham2gmail.com> Closes pandas-dev#15224 from jreback/mi_hash2 and squashes the following commits: 8b1d3f9 [Jeff Reback] not correctly hashing categorical in a MI 48a2402 [Jeff Reback] support for mixed type arrays 58f682d [Jeff Reback] memory optimization 0c13df7 [Mike Graham] Steal the algorithm used to combine hashes from tupleobject.c e8dd607 [Jeff Reback] add hash_tuples 44e9c7d [Mike Graham] wipSteal the algorithm used to combine hashes from tupleobject.c e507c4a [Jeff Reback] ENH: support MultiIndex and tuple hashing
on top of #15216
closes #15227