CLN: remove deprecated google-analytics module (GH11308) #15223
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
jreback
approved these changes
Jan 25, 2017
| @@ -163,7 +163,7 @@ Other enhancements: | |||
| p.all() | |||
|
|
|||
| - Added support for ``utcfromtimestamp()``, ``fromtimestamp()``, and ``combine()`` on `Timestamp` class (:issue:`5351`). | |||
| - Added Google Analytics (`pandas.io.ga`) basic documentation (:issue:`8835`). See :ref:`here<remote_data.ga>`. | |||
| - Added Google Analytics (`pandas.io.ga`) basic documentation (:issue:`8835`). See `here<http://pandas.pydata.org/pandas-docs/version/0.15.2/remote_data.html#remote-data-ga>`__. | |||
There was a problem hiding this comment.
hmm maybe put in the fact that it's removed after 0.19.0?
There was a problem hiding this comment.
Hmm, I don't want to start updating whatsnew files if we change things (there are other mentions of the ga moudels in whatsnew files as well). In principle no one should read this now anymore ..
I just wanted to make sure to not have a doc build warning about a non-existing label, could remove the link altogether as well.
Current coverage is 86.31% (diff: 100%)@@ master #15223 diff @@
==========================================
Files 140 139 -1
Lines 51272 51082 -190
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 44087 44089 +2
+ Misses 7185 6993 -192
Partials 0 0
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.