BUG: TimedeltaIndex raising ValueError when boolean indexing (#14946) #15221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
added
Bug
Indexing
jreback
requested changes
Jan 25, 2017
| @@ -2052,6 +2052,22 @@ def test_add_overflow(self): | |||
| to_timedelta(['7 seconds', pd.NaT, '4 hours'])) | |||
| tm.assert_index_equal(result, exp) | |||
|
|
|||
| def test_boolean_indexing(self): | |||
| # GH 14946 | |||
There was a problem hiding this comment.
put this in pandas/tests/indexing
create a new class for TimedeltaIndex
might be some other timedelta indexing routines you can group with it
Current coverage is 86.31% (diff: 100%)@@ master #15221 diff @@
==========================================
Files 139 139
Lines 51091 51093 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 44099 44101 +2
Misses 6992 6992
Partials 0 0
|
|
Moved the tests to |
jreback
approved these changes
Jan 26, 2017
|
thanks @mroeschke keep em coming! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
…dev#14946) closes pandas-dev#14946 Author: Matt Roeschke <[email protected]> Closes pandas-dev#15221 from mroeschke/fix_14946 and squashes the following commits: b8ac04e [Matt Roeschke] BUG: TimedelaIndex raising ValueError when boolean indexing (pandas-dev#14946)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffImplementing patch suggested by @jreback here that prevents raising a
ValueErrorwhen boolean indexing with aTimedeltaIndex