Skip to content

BLD: add locale to 34_nslow build #15211

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Jan 24, 2017

No description provided.

@jreback jreback added the Build Library building on various platforms label Jan 24, 2017
@jreback jreback added this to the 0.20.0 milestone Jan 24, 2017
@jreback jreback mentioned this pull request Jan 24, 2017
4 tasks
@bashtage
Copy link
Contributor

You might need

      addons:
        apt:
          packages:
          - language-pack-zh-hans

@bashtage
Copy link
Contributor

I don't know how job name and cache name work, but there are 2 with the name 34_nslow and the same cache.

@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2017

@bashtage there are always 2 when you have an allowed failure.

@bashtage
Copy link
Contributor

Python 2/3 Unicode challenges.

@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2017

yep I just put it upagain using ZH on 2.7, so will see.

@bashtage
Copy link
Contributor

Just did a quick local check and it looks like my patch for the date problem fixes Python 3 issues in stata.

@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2017

@bashtage do we have a test for this? (IOW, the above shows no issues in master on py3).

@bashtage
Copy link
Contributor

All of these failures

https://travis-ci.org/jreback/pandas/jobs/194872508

are the same bug with locale being used for strftime. There didn't seem to be a specific test needed since it was already being hit in lots of existing tests.

@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2017

hmm, I must have cancelled it too soon (or was looking at the wrong build). ok so this fails on py3. great, going to merge the original change then (running ZH on 3.4).

@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2017

this surfaced an addition (non-stata error)

======================================================================
ERROR: test_to_datetime_format_microsecond (pandas.tseries.tests.test_timeseries.TimeConversionFormats)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/travis/build/jreback/pandas/pandas/tseries/tools.py", line 407, in _convert_listlike
    values, tz = tslib.datetime_to_datetime64(arg)
  File "pandas/tslib.pyx", line 1756, in pandas.tslib.datetime_to_datetime64 (pandas/tslib.c:30671)
    raise TypeError('Unrecognized value type: %s' % type(val))
TypeError: Unrecognized value type: <class 'str'>
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
  File "/home/travis/build/jreback/pandas/pandas/tseries/tests/test_timeseries.py", line 5374, in test_to_datetime_format_microsecond
    result = to_datetime(val, format=format)
  File "/home/travis/build/jreback/pandas/pandas/tseries/tools.py", line 427, in to_datetime
    return _convert_listlike(np.array([arg]), box, format)[0]
  File "/home/travis/build/jreback/pandas/pandas/tseries/tools.py", line 410, in _convert_listlike
    raise e
  File "/home/travis/build/jreback/pandas/pandas/tseries/tools.py", line 377, in _convert_listlike
    errors=errors)
  File "pandas/tslib.pyx", line 3600, in pandas.tslib.array_strptime (pandas/tslib.c:58664)
    raise ValueError("time data %r does not match "
ValueError: time data '01-Apr-2011 00:00:01.978' does not match format '%d-%b-%Y %H:%M:%S.%f' (match)

@jreback
Copy link
Contributor Author

jreback commented Jan 24, 2017

@bashtage going to merge this one: https://travis-ci.org/jreback/pandas/jobs/194920988

which your PR should fix all but 1 of these I think (the one above needs more looking), so i'll create an issue.

@jreback jreback closed this in 699d5e5 Jan 24, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Author: Jeff Reback <[email protected]>

Closes pandas-dev#15211 from jreback/nslow and squashes the following commits:

7dd0fac [Jeff Reback] TST: skip some non-us locale tests with guessing datetimes
a7c90e1 [Jeff Reback] BLD: add locale to 34_nslow build
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants