BUG: GH14233 resample().median() failed if duplicate column names wer… #15202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Jan 23, 2017
| @@ -2203,7 +2203,6 @@ def agg_series(self, obj, func): | |||
| # cython aggregation | |||
|
|
|||
| _cython_functions = copy.deepcopy(BaseGrouper._cython_functions) | |||
| _cython_functions['aggregate'].pop('median') | |||
There was a problem hiding this comment.
hmm, I remember something was failing because of this.......
There was a problem hiding this comment.
I ran nosetests locally, and it works. I looked back at old versions, and I think it is a legacy issue of how the cython stuff was implemented over time.
jreback
requested changes
Jan 23, 2017
| def test_median_duplicate_columns(self): | ||
| # GH 14233 | ||
|
|
||
| df = pd.DataFrame(np.array([[i + j for i in range(20)] |
There was a problem hiding this comment.
can you use the repro from the original issue?
There was a problem hiding this comment.
Only difference is using np.random.randn() versus the sequence I put in there, which makes it easier to debug. I can put the randn() if you want.
jreback
approved these changes
Jan 24, 2017
|
lgtm. ping on green. |
|
thanks! |
AnkurDedania
pushed a commit
to AnkurDedania/pandas
that referenced
this pull request
Mar 21, 2017
Simple fix for median issue. Should use cython implementation. closes pandas-dev#14233 Author: Dr-Irv <[email protected]> Closes pandas-dev#15202 from Dr-Irv/Issue14233 and squashes the following commits: 6e0d900 [Dr-Irv] Use randn in test 1a3b4aa [Dr-Irv] BUG: GH14233 resample().median() failed if duplicate column names were present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for median issue. Should use cython implementation.
git diff upstream/master | flake8 --diff