BLD: Remove csv dialect warning in io.rst #15177
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
maybe I wasn't clear. Is this a legit warning? |
Current coverage is 85.54% (diff: 100%)@@ master #15177 diff @@
==========================================
Files 145 145
Lines 51406 51406
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43978 43977 -1
- Misses 7428 7429 +1
Partials 0 0
|
|
IMO it should not warn. But that was what I advocated for in the PR #14911, and I lost that argument .. So @jreback "is this a legit warning?", yes, given how we merged the PR, this warning is expected and not really avoidable (just annoying and IMO unnecessary). So using |
|
ok then |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Title is self-explanatory.
xref #14911 (comment).