Skip to content

Apply fontsize to both x- and y-axis tick labels #15161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 20, 2017
Merged

Apply fontsize to both x- and y-axis tick labels #15161

merged 3 commits into from
Jan 20, 2017

Conversation

cbrnr
Copy link
Contributor

@cbrnr cbrnr commented Jan 19, 2017 •
edited
Loading

@sinhrks
Copy link
Member

sinhrks commented Jan 19, 2017

Pls add tests to check font size, using _check_ticks_props.

@sinhrks sinhrks added the Visualization plotting label Jan 19, 2017
@cbrnr
Copy link
Contributor Author

cbrnr commented Jan 19, 2017 •
edited
Loading

Sure - I added a test for both TestDataFramePlots and TestDataFrameGroupByPlots. Let me know if only one test (the former?) is sufficient though.

@sinhrks
Copy link
Member

sinhrks commented Jan 20, 2017

lgtm. pls add whats new note.

@TomAugspurger ?

@cbrnr
Copy link
Contributor Author

cbrnr commented Jan 20, 2017

OK - I hope this was the right place to add the note.

@TomAugspurger TomAugspurger merged commit b342331 into pandas-dev:master Jan 20, 2017
@TomAugspurger
Copy link
Contributor

Thanks!

AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
@cbrnr @AnkurDedania
Apply fontsize to both x- and y-axis tick labels (pandas-dev#15161)
31f4721 
* Apply fontsize to both x- and y-axis tick labels

* Add tests

* Add note in whatsnew
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jorisvandenbossche jorisvandenbossche jorisvandenbossche approved these changes

Assignees
No one assigned
Labels
Visualization plotting
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

boxplot fontsize argument only works on x axis (and not on y axis)
4 participants
@cbrnr @sinhrks @TomAugspurger @jorisvandenbossche