-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
TST: Add another test for uneven CSV rows #15114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: Add another test for uneven CSV rows #15114
Conversation
Current coverage is 84.75% (diff: 100%)@@ master #15114 diff @@
==========================================
Files 145 145
Lines 51232 51232
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43420 43420
Misses 7812 7812
Partials 0 0
|
@gfyoung Is this kind of CSV currently untested? |
It is, but to be safe we always include test cases from issues we close. |
Indeed, we do, but in this case it does seem like almost exactly the same test as the one above but with different numbers? (only usage of header or not, but I don't think this should matter?) |
@jorisvandenbossche : It shouldn't, but more tests couldn't hurt 😄 |
@gfyoung I also changed the 'closes ..', as I would like to keep the issue open for the discussion about the |
@jorisvandenbossche : I'm changing it back because #5986 and #9729 are better places to have this IMO (we should de-duplicate discussions if possible). |
more tests start to hurt when we don't see the wood for the trees anymore |
@jorisvandenbossche : Meant #5686 (sorry!) I don't fully understand what you said there (might be the forest-trees idiom) |
yet I looked it up before posting to be sure it was correct English :-) http://dictionary.cambridge.org/dictionary/english/not-see-the-wood-for-the-trees. With too many tests, it is more difficult to keep the overview |
Title is self-explanatory.
xref #15066.
Closes #9549.