Skip to content

PERF: improve perf of float-based timeseries plotting #15073

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

jorisvandenbossche
Copy link
Member

xref #15071

_dt_to_float_ordinal was already vectorized, so no need to map it on the index.

So now is 'irregular' plotting even faster as period-based plotting:

$ asv continuous upstream/master HEAD -b TimeseriesPlotting
...
· Running 4 total benchmarks (2 commits * 1 environments * 2 benchmarks)
[  0.00%] · For pandas commit hash 4fc0dca6:
[  0.00%] ·· Benchmarking conda-py2.7-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 25.00%] ··· Running plotting.TimeseriesPlotting.time_plot_regular             126.57ms
[ 50.00%] ··· Running plotting.TimeseriesPlotting.time_plot_regular_compat      87.57ms
[ 50.00%] · For pandas commit hash de09c988:
[ 50.00%] ·· Benchmarking conda-py2.7-Cython-matplotlib-numexpr-numpy-openpyxl-pytables-scipy-sqlalchemy-xlrd-xlsxwriter-xlwt
[ 75.00%] ··· Running plotting.TimeseriesPlotting.time_plot_regular             126.01ms
[100.00%] ··· Running plotting.TimeseriesPlotting.time_plot_regular_compat      305.58ms    

      before     after       ratio
  [de09c988] [4fc0dca6]
-  305.58ms    87.57ms      0.29  plotting.TimeseriesPlotting.time_plot_regular_compat

@jorisvandenbossche jorisvandenbossche added Performance Memory or execution speed performance Visualization plotting labels Jan 6, 2017
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Jan 6, 2017
@codecov-io
Copy link

codecov-io commented Jan 6, 2017

Current coverage is 84.75% (diff: 100%)

Merging #15073 into master will not change coverage

@@             master     #15073   diff @@
==========================================
  Files           145        145          
  Lines         51151      51151          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43355      43355          
  Misses         7796       7796          
  Partials          0          0          

Powered by Codecov. Last update db08da2...3971d56

@jreback
Copy link
Contributor

jreback commented Jan 9, 2017

lgtm.

@jorisvandenbossche jorisvandenbossche merged commit e1a4144 into pandas-dev:master Jan 9, 2017
@jreback
Copy link
Contributor

jreback commented Jan 10, 2017

https://travis-ci.org/pandas-dev/pandas/jobs/190356982

I think this broke something on the slow 3.4 build ?

jreback added a commit to jreback/pandas that referenced this pull request Jan 10, 2017
jreback added a commit to jreback/pandas that referenced this pull request Jan 10, 2017
jreback added a commit to jreback/pandas that referenced this pull request Jan 11, 2017
jreback added a commit to jreback/pandas that referenced this pull request Jan 11, 2017
jreback added a commit to jreback/pandas that referenced this pull request Jan 11, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
AnkurDedania pushed a commit to AnkurDedania/pandas that referenced this pull request Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Performance Memory or execution speed performance Visualization plotting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants