pathlib support in pytables #15064
Closed
pathlib support in pytables #15064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pls add testing (look how the test r done elsewhere for pathlib) and a whatsnew note |
sinhrks
added
Bug
Compat
|
can you rebase / update |
|
closing as stale, but if you'd like to add tests and update, pls ping. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffAs we talked about on gitter, I added the line (https://github.com/pandas-dev/pandas/blob/master/pandas/io/pytables.py#L266) to the HDFStore.open function. Let me know if I misunderstood or should make further edits, thank you!