-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
add the 'name' attribute to dataframes that go through apply_frame_axis0 #15062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add the 'name' attribute to dataframes that go through apply_frame_axis0 #15062
Conversation
Current coverage is 85.97% (diff: 100%)@@ master #15062 diff @@
==========================================
Files 140 140
Lines 51263 51263
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 44076 44075 -1
- Misses 7187 7188 +1
Partials 0 0
|
looks innocuous enough (famous last words). did you have a higher level usage that was triggering this? |
can you add an asv for this? and add a whatsnew note (perf improvements). |
ping @llllllllll |
Sorry about letting this sit idle. I will try to get the asv report and what's new on Monday. |
np, ping when ready. |
dbb3a4a
to
722a945
Compare
ping: I ran the suite locally but it was pretty noisy. I won't be run this without having other stuff running in the background until sometime tonight. |
@llllllllll lgtm. just report on perf when you can. I also think that the |
@llllllllll can you rebase; ping on green. i think this was ok. |
from what I remember I was going to add a performance case for the asv suite. I had one locally but I actually saw a performance regression and didn't have time to dig deeper. I can rebase but I am not sure if we want to merge with the open question. |
@llllllllll looks like you add an example in the asv. if you can rebase and just show/before after on that example would be fine. |
thanks @llllllllll rebased and merged. |
…ame_axis0 Previously, if you did `group.name` in the applied function, it would fail and fall back to the slower path because the attribute did not exist; `shape_before` was unused. Author: Joe Jevnik <[email protected]> This patch had conflicts when merged, resolved by Committer: Jeff Reback <[email protected]> Closes pandas-dev#15062 from llllllllll/add-name-in-apply-inference-call and squashes the following commits: 722a945 [Joe Jevnik] DOC: update whatsnew for groupby perf change 7e75635 [Joe Jevnik] DEV: add groupby asv benchmark 710528a [Joe Jevnik] BUG: add the 'name' attribute to dataframes that go through apply_frame_axis0
git diff upstream/master | flake8 --diff
Previously, if you did
group.name
in the applied function, it would fail and fall back to the slower path because the attribute did not exist.shape_before
was unused.