TST: Test empty method and simplify logic #15043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.75% (diff: 100%)@@ master #15043 diff @@
==========================================
Files 145 145
Lines 51146 51146
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43350 43351 +1
+ Misses 7796 7795 -1
Partials 0 0
|
jreback
reviewed
Jan 3, 2017
| s_empty = pd.Series() | ||
| tm.assert_equal(s_empty.empty, True) | ||
|
|
||
| for full_series in [pd.Series([1]), pd.Series(index=[1])]: |
There was a problem hiding this comment.
look in tests/frame/test_misc_api.py (and series). prob some panel tests already.
you can add cases to there if needed
Add test for empty method Move tests
|
Tests moved and all green. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffSince the docstring of
.emptystatesI was wondering if the logic could be changed accordingly for code clarity. Unless it was set as
not all(len(self._get_axis(a)) > 0 for a in self._AXIS_ORDERS)for a particular reason.Also this method did not appear to have any test.