BUG: Indexing MultiIndex with Series failed. #15041
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, accessing elements of a MultiIndex-indexed DataFrame with a Series failed. This changes that behavior so that it is possible to use a Series to access elements from a MultiIndex-indexed DataFrame, just as one would use a list.
jreback
requested changes
Jan 3, 2017
| # GH14730 | ||
| index = MultiIndex.from_product([[1, 2, 3], ['A', 'B', 'C']]) | ||
| x = Series(index=index, data=range(9)) | ||
| y = Series([1, 3]) |
There was a problem hiding this comment.
put this is tests/test_multilevel or test_indexing
find a very similar test (iow indexing a mi with list/ndarray) and put after
| actual_from_series = x.loc[y] | ||
| actual_from_list = x.loc[[1, 3]] | ||
| tm.assert_series_equal(expected, actual_from_list) | ||
| tm.assert_series_equal(expected, actual_from_series) |
There was a problem hiding this comment.
result = ...
expected = ....
assert_series_equal(result, expected)
| actual_from_list = x.loc[[1, 3]] | ||
| tm.assert_series_equal(expected, actual_from_list) | ||
| tm.assert_series_equal(expected, actual_from_series) | ||
|
|
||
| def test_set_levels_categorical(self): | ||
| # GH13854 |
| @@ -1461,6 +1461,9 @@ def _getitem_axis(self, key, axis=0): | |||
| if isinstance(labels, MultiIndex): | |||
| if (not isinstance(key, tuple) and len(key) > 1 and | |||
| not isinstance(key[0], tuple)): | |||
| if isinstance(key, ABCSeries): | |||
| # GH 14730 | |||
There was a problem hiding this comment.
you can prob just
list(key)
There was a problem hiding this comment.
I thought taking the .values was more explicit, but list is probably more familiar. Changed.
There was a problem hiding this comment.
no .values is fraught with issues as it converts dtypes, we don't use it internally if at all possible.
sinhrks
added
Bug
Indexing
Current coverage is 84.75% (diff: 100%)@@ master #15041 diff @@
==========================================
Files 145 145
Lines 51129 51141 +12
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43343 43345 +2
- Misses 7786 7796 +10
Partials 0 0
|
added 2 commits
January 3, 2017 10:38
|
thanks @bkandel (I moved the tests to the appropriate location) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, accessing elements of a MultiIndex-indexed DataFrame with a Series
failed. This changes that behavior so that it is possible to use a Series to
access elements from a MultiIndex-indexed DataFrame, just as one would use
a list.
git diff upstream/master | flake8 --diff