BUG: Patch float and uint handling in to_numeric #15024
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.77% (diff: 100%)@@ master #15024 diff @@
==========================================
Files 145 145
Lines 51123 51123
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43337 43337
Misses 7786 7786
Partials 0 0
|
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
floathandling by reducing the "closeness" level when checking conversions.uinthandling by allowing casts touintdtypes of equal or lesser size toint64(when values are less thanINT64_MAXCloses #14941.
Follow-up to #15005.