BUG: fixed index power operation #14996
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* The power operation on a range of indexes was fixed. See issue #14973
4 tasks
jreback
reviewed
Dec 27, 2016
| @@ -105,6 +105,21 @@ def test_numeric_compat(self): | |||
| for r, e in zip(result, expected): | |||
| tm.assert_index_equal(r, e) | |||
|
|
|||
| #test power calculations both ways | |||
There was a problem hiding this comment.
model this after the existing code, IOW, use idx which is already define.
add a comment with this issue number.
There was a problem hiding this comment.
Thank you for your guidance. Changes implemented.
jreback
reviewed
Dec 27, 2016
| pow_range = 2.0**num_range | ||
| idxs = pd.Float64Index(range(1, 11)) | ||
|
|
||
| expected_pow_values = pd.Float64Index(pow_range) |
jreback
reviewed
Dec 27, 2016
| @@ -282,6 +282,7 @@ Performance Improvements | |||
| Bug Fixes | |||
| ~~~~~~~~~ | |||
|
|
|||
| - Bug in ``Indexes`` Power numerical operations did not operate correctly (:issue:`14973`) | |||
There was a problem hiding this comment.
Bug in Index power operations with with reversed operands
jreback
added
Bug
Numeric Operations
* Changed variable names to follow code standards * Changed changelog to correct wording * Added Github issue in comment to follow documentation standard
Current coverage is 84.78% (diff: 100%)@@ master #14996 diff @@
==========================================
Files 145 145
Lines 51090 51091 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43315 43317 +2
+ Misses 7775 7774 -1
Partials 0 0
|
|
@jreback anything more I can do to have it accepted? |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff