BUG: Series.ffill() with mixed dtypes containing tz-aware datetimes f… #14960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 84.65% (diff: 100%)@@ master #14960 diff @@
==========================================
Files 144 144
Lines 51043 51043
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43214 43213 -1
- Misses 7829 7830 +1
Partials 0 0
|
jreback
reviewed
Dec 23, 2016
| @@ -300,3 +300,4 @@ Bug Fixes | |||
| - Bug in ``Series.unique()`` in which unsigned 64-bit integers were causing overflow (:issue:`14721`) | |||
| - Require at least 0.23 version of cython to avoid problems with character encodings (:issue:`14699`) | |||
| - Bug in converting object elements of array-like objects to unsigned 64-bit integers (:issue:`4471`) | |||
| - Bug in Series.ffill() with mixed dtypes containing tz-aware datetimes. (:issue: `14956`) | |||
There was a problem hiding this comment.
no space after the (:issue:`14956`)
|
pls add a test in pandas.types.tests.test_inference for the inference check otherwise lgtm. |
jreback
added
Bug
Dtype Conversions
grutts
force-pushed
the
pandas_issue_14956
branch
from
20d96e0 to
4c6b9ba
Compare
|
Added some simple tests and corrected whitespace issue. Please let me know if you'd like some more extensive/different testing. |
|
@grutts lgtm. ping on green. |
grutts
force-pushed
the
pandas_issue_14956
branch
from
4c6b9ba to
8550ed1
Compare
|
@jreback all green. Had to make another commit to pass PEP8 |
|
thanks! note I had to add an option to the test_inference test to make it fail w/o the change. The importance of testing first before the fix. |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ails. (GH14956)
Seems to work with all the datetime classes usually encountered, although 'tz' seems to be the idiom in the codebase (not sure why?). If both need to be supported I can replace
getattr(val, 'tzinfo', None)withgetattr(val, 'tz', None) or getattr(val, 'tzinfo', None), thus also giving precedence to the former (if available).(breaking commit was 4de83d2)
git diff upstream/master | flake8 --diff