TST: Groupby.filter dropna=False with empty group (#10780) #14926
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Bug
Groupby
Testing
jreback
reviewed
Dec 20, 2016
| # GH 10780 | ||
| data = pd.Series(np.random.rand(9), index=np.repeat([1, 2, 3], 3)) | ||
| groupped = data.groupby(level=0) | ||
| result = groupped.filter(lambda x: x.mean() > 1, dropna=False) |
There was a problem hiding this comment.
can you add testing for dropna=True as well, for completeness
Current coverage is 84.65% (diff: 100%)@@ master #14926 diff @@
==========================================
Files 144 144
Lines 51023 51023
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43190 43191 +1
+ Misses 7833 7832 -1
Partials 0 0
|
Add test for dropna = True
mroeschke
force-pushed
the
test_10780
branch
from
74ed10c to
ee4ce0f
Compare
|
Added test for |
|
thanks! |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
…andas-dev#14926) Add test for dropna = True
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffDidn't find a PR in 0.20 or 0.19.2 that closed this, but works on master 0.19.1