TST: Test empty input for read_csv (#14867) #14920
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
reviewed
Dec 19, 2016
| @@ -392,6 +393,16 @@ def test_empty_field_eof(self): | |||
| names=list('abcd'), engine='c') | |||
| assert_frame_equal(df, c) | |||
|
|
|||
| def test_empty_csv_input(self): | |||
| # GH14867 | |||
| df1 = read_csv(StringIO(), chunksize=20, header=None, | |||
There was a problem hiding this comment.
I would just write a temporary blank file here instead of adding an external file (or even better, just use a StringIO that is empty, or whatever you need)
There was a problem hiding this comment.
OK. I am using an empty StringIO in the first test, so sounds like the second test using the external file is redundant. Should I just submit the first test only then?
There was a problem hiding this comment.
if they behave the same then ok with it (you can add it if you want, but again, use a temp file)
jreback
added
IO CSV
Current coverage is 84.64% (diff: 100%)@@ master #14920 diff @@
==========================================
Files 144 144
Lines 51016 51016
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43184 43185 +1
+ Misses 7832 7831 -1
Partials 0 0
|
Fixed flake8 issues Added blank csv file Removing unneeded test
jeffcarey
force-pushed
the
test/14867
branch
from
7bdde48 to
46ad2a2
Compare
|
Removed the extra test, all good now. |
|
thanks! |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
Fixed flake8 issues Added blank csv file Removing unneeded test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
read_csvwith chunksize set returns emptyDataFrameInstead ofTextFileReader#14867git diff upstream/master | flake8 --diffLMK if it would be more suitable in a different test file.