BUG: Fixed DataFrame.describe percentiles are ndarray w/ no median #14914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thx, can u add tests and whatsnew? |
sinhrks
reviewed
Dec 19, 2016
| @@ -5255,6 +5255,9 @@ def abs(self): | |||
|
|
|||
| @Appender(_shared_docs['describe'] % _shared_doc_kwargs) | |||
| def describe(self, percentiles=None, include=None, exclude=None): | |||
| # explicit conversion of `percentiles` to list | |||
| percentiles = list(percentiles) | |||
There was a problem hiding this comment.
this looks fail by default percentiles=None.
There was a problem hiding this comment.
Right - I think I could just move it under if percentiles is not None: instead
sinhrks
added
Bug
Numeric Operations
Current coverage is 84.64% (diff: 100%)@@ master #14914 diff @@
==========================================
Files 144 144
Lines 51057 51016 -41
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43180 43185 +5
+ Misses 7877 7831 -46
Partials 0 0
|
jreback
reviewed
Dec 19, 2016
| @@ -996,6 +996,15 @@ def test_describe_percentiles_insert_median(self): | |||
| self.assertTrue('0%' in d1.index) | |||
| self.assertTrue('100%' in d2.index) | |||
|
|
|||
| def test_describe_percentiles_insert_median_ndarray(self): | |||
| df = tm.makeDataFrame() | |||
There was a problem hiding this comment.
add the issue number here as a comment
jreback
reviewed
Dec 19, 2016
| @@ -996,6 +996,15 @@ def test_describe_percentiles_insert_median(self): | |||
| self.assertTrue('0%' in d1.index) | |||
| self.assertTrue('100%' in d2.index) | |||
|
|
|||
| def test_describe_percentiles_insert_median_ndarray(self): | |||
| df = tm.makeDataFrame() | |||
| try: | |||
There was a problem hiding this comment.
you don't need the try/except at all; nose will simply fail the test if this raises.
rename d1 -> result, d2 -> expected
|
small changes. ping on green. |
|
lgtm. ping on green. |
|
thanks! |
ShaharBental
pushed a commit
to ShaharBental/pandas
that referenced
this pull request
Dec 26, 2016
Explicit conversion to list for `percentiles`. Fixes the case where `percentiles` is passed as a numpy with no median (0.5) present. Closes pandas-dev#14908. Author: pbreach <[email protected]> Closes pandas-dev#14914 from pbreach/df-describe-percentile-ndarray-no-median and squashes the following commits: 5c8199b [pbreach] Minor test fix b5d09a6 [pbreach] Added test for median insertion with ndarray 72fe0cb [pbreach] Added what's new entry f954392 [pbreach] Moved conversion to if percentiles is not None d192ac7 [pbreach] Fixed whitespace issue a06794d [pbreach] BUG: Fixed bug in DataFrame.describe when percentiles are passed as array with no median
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicit conversion to list for
percentiles. Fixes the case wherepercentilesis passed as a numpy with no median (0.5) present. Closes #14908.