Clean up construction of Series with dictionary and datetime index #14895
Conversation
…ception that was then caught; add ASV that show slight improvement
sinhrks
added
Performance
|
Thx for the PR! can u paste the vbench result? |
|
lgtm. pls add a whatsnew in 0.19.2 (perf section). |
|
asv continuous -f 1.1 upstream/master HEAD -b series_methods.series_constructor_dict_data_datetime_index
SOME BENCHMARKS HAVE CHANGED SIGNIFICANTLY. |
Current coverage is 85.31% (diff: 100%)@@ master #14895 diff @@
==========================================
Files 144 144
Lines 51016 51015 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43522 43522
+ Misses 7494 7493 -1
Partials 0 0
|
| goal_time = 0.2 | ||
|
|
||
| def setup(self): | ||
| self.dr = pd.date_range( |
There was a problem hiding this comment.
can you make this 1/10th the size (it will still show the differences), just generally don't want to have have 3 second functions. ping when you push as the rest is ok.
|
thanks! (I adjusted the asv slightly) |
closes pandas-dev#14894 Fix usage of fast_multiget with index which was always throwing an exception that was then caught; add ASV that show slight improvement Author: Nate Yoder <[email protected]> Closes pandas-dev#14895 from nateyoder/series_dict_index and squashes the following commits: 56be091 [Nate Yoder] Update whatsnew and fix pep8 issue 5f05fdc [Nate Yoder] Fix usage of fast_multiget with index which was always throwing an exception that was then caught; add ASV that show slight improvement
closes pandas-dev#14894 Fix usage of fast_multiget with index which was always throwing an exception that was then caught; add ASV that show slight improvement Author: Nate Yoder <[email protected]> Closes pandas-dev#14895 from nateyoder/series_dict_index and squashes the following commits: 56be091 [Nate Yoder] Update whatsnew and fix pep8 issue 5f05fdc [Nate Yoder] Fix usage of fast_multiget with index which was always throwing an exception that was then caught; add ASV that show slight improvement (cherry picked from commit e503d40)
closes pandas-dev#14894 Fix usage of fast_multiget with index which was always throwing an exception that was then caught; add ASV that show slight improvement Author: Nate Yoder <[email protected]> Closes pandas-dev#14895 from nateyoder/series_dict_index and squashes the following commits: 56be091 [Nate Yoder] Update whatsnew and fix pep8 issue 5f05fdc [Nate Yoder] Fix usage of fast_multiget with index which was always throwing an exception that was then caught; add ASV that show slight improvement
git diff upstream/master | flake8 --diffFix usage of fast_multiget with index which was always throwing an exception that was then caught; add ASV that show slight improvement