Fixed KDE Plot to drop the missing values #14820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keshavramaswamy
changed the title
keshavramaswamy
changed the title
Current coverage is 85.30% (diff: 100%)@@ master #14820 diff @@
==========================================
Files 144 144
Lines 50957 51004 +47
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43469 43511 +42
- Misses 7488 7493 +5
Partials 0 0
|
|
Can you add a test and a release note in whatsnew/0.19.2? |
|
Yes, I can do that |
jreback
added
Missing-data
|
can you rebase, problem with appeveyor which i just fixed |
|
Sure, I'll do that!
…On Sat, Dec 10, 2016 at 10:33 AM Jeff Reback ***@***.***> wrote:
can you rebase, problem with appeveyor which i just fixed
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#14820 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AGg1E01seEPTO65FIZGUbq1__9zCTGicks5rGsZfgaJpZM4LHV8J>
.
|
TomAugspurger
requested changes
Dec 11, 2016
There was a problem hiding this comment.
Still need a test too. That can go in pandas/tests/plotting/test_series.py There's already a test in there with missing values test_kde_missing_vals, apparently not the right mix of missing values though.
Put a comment with a link to this issue when you make the new test. Thanks!
| @@ -78,4 +78,8 @@ Bug Fixes | |||
|
|
|||
| - Explicit check in ``to_stata`` and ``StataWriter`` for out-of-range values when writing doubles (:issue:`14618`) | |||
|
|
|||
| <<<<<<< HEAD | |||
There was a problem hiding this comment.
You can remove the git conflict markers.
There was a problem hiding this comment.
yes, I noticed that - will add the required test too asap!
|
@jreback - Is there a problem with the Travis CI? |
|
you need to rebase on current master, I fixed this yesterday. |
|
Thanks @jreback - have rebased now. |
| axes = _check_plot_works(s.plot.kde) | ||
| # check if the values have any missing values | ||
| # GH14821 | ||
| self.assertTrue(any(~np.isnan(axes.lines[0]._xorig)), |
There was a problem hiding this comment.
Can you replace the ._xorig with .get_xdata()? Better to not use matplotlib's internal APIs.
|
One small change, then we should be good! We're aware of that travis failure on the 3.4 build. |
TomAugspurger
approved these changes
Dec 14, 2016
|
@keshavramaswamy thanks! |
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
BUG: Fixed KDE plot to ignore missing values closes pandas-dev#14821 * fixed kde plot to ignore the missing values * added comment to elaborate the changes made * added a release note in whatsnew/0.19.2 * added test to check for missing values and cleaned up whatsnew doc * added comment to refer the issue * modified to fit lint checks * replaced ._xorig with .get_xdata()
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Dec 24, 2016
BUG: Fixed KDE plot to ignore missing values closes pandas-dev#14821 * fixed kde plot to ignore the missing values * added comment to elaborate the changes made * added a release note in whatsnew/0.19.2 * added test to check for missing values and cleaned up whatsnew doc * added comment to refer the issue * modified to fit lint checks * replaced ._xorig with .get_xdata() (cherry picked from commit 033d345)
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Jan 3, 2017
Version 0.19.2 * tag 'v0.19.2': (78 commits) RLS: v0.19.2 DOC: update release notes for 0.19.2 TST: skip gbq upload test as flakey DOC: clean-up v0.19.2 whatsnew DOC: update Pandas Cheat Sheet (GH13202) DOC: Pandas Cheat Sheet TST: matplotlib 2.0 fix in log limits for barplot (GH14808) (pandas-dev#14957) flake8 fix import Remove test - from 0.20.0 PR slipped in PERF: fix getitem unique_check / initialization issue cache and remove boxing (pandas-dev#14931) CLN: Resubmit of GH14700. Fixes GH14554. Errors other than Indexing… Clean up construction of Series with dictionary and datetime index BUG: .fillna() for datetime64 with tz is passing thru floats BUG: Patch read_csv NA values behaviour ENH: merge_asof() has type specializations and can take multiple 'by' parameters (pandas-dev#13936) [Backport pandas-dev#14886] BUG: regression in DataFrame.combine_first with integer columns (GH14687) (pandas-dev#14886) Fixed KDE Plot to drop the missing values (pandas-dev#14820) ENH: merge_asof() has left_index/right_index and left_by/right_by (pandas-dev#14253) (pandas-dev#14531) TST: correct url for test file on s3 (xref pandas-dev#14587) ...
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Jan 3, 2017
* releases: (78 commits) RLS: v0.19.2 DOC: update release notes for 0.19.2 TST: skip gbq upload test as flakey DOC: clean-up v0.19.2 whatsnew DOC: update Pandas Cheat Sheet (GH13202) DOC: Pandas Cheat Sheet TST: matplotlib 2.0 fix in log limits for barplot (GH14808) (pandas-dev#14957) flake8 fix import Remove test - from 0.20.0 PR slipped in PERF: fix getitem unique_check / initialization issue cache and remove boxing (pandas-dev#14931) CLN: Resubmit of GH14700. Fixes GH14554. Errors other than Indexing… Clean up construction of Series with dictionary and datetime index BUG: .fillna() for datetime64 with tz is passing thru floats BUG: Patch read_csv NA values behaviour ENH: merge_asof() has type specializations and can take multiple 'by' parameters (pandas-dev#13936) [Backport pandas-dev#14886] BUG: regression in DataFrame.combine_first with integer columns (GH14687) (pandas-dev#14886) Fixed KDE Plot to drop the missing values (pandas-dev#14820) ENH: merge_asof() has left_index/right_index and left_by/right_by (pandas-dev#14253) (pandas-dev#14531) TST: correct url for test file on s3 (xref pandas-dev#14587) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff