Skip to content

Changed pandas-qt python2/3 friendly qtpandas. #14818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 29, 2016

Conversation

draperjames
Copy link

Just changed the link to the abandoned repository python 2 only pandas-qt to the new functional Python 2/3 friendly qtpandas.

Just changed the link to the abandoned repository python 2 only pandas-qt to the new functional Python 2/3 friendly qtpandas.
@draperjames
Copy link
Author

I don't know why appveyor failed. I just changed line in the docs are tests even required?

@jorisvandenbossche
Copy link
Member

@draperjames the failure is not related to your PR (we have some problems with appveyor at the moment), just look for travis

Can you provide some more explanation for this PR? Why the change? Is this a successor of the other project or a fork? Better maintained?

@draperjames
Copy link
Author

Can you provide some more explanation for this PR?

  • Sure

Why the change?

  • pandas-qt doesn't support for python3. also the maintainer has shown no interest in it for a while.

Is this a successor of the other project or a fork?

  • This is a fork of the project but the namespace has been changed from pandasqt to qtpandas. We aren't happy about that either but there was no real way around it.

Better maintained?

  • We can only hope. @zbarge and I (@draperjames) are currently maintaining the repo on github and it's pip. So if we are just talking about people with access its twice as well maintained. We are looking for people that would be interested in helping build it out.

@draperjames
Copy link
Author

draperjames commented Dec 8, 2016

@jorisvandenbossche Is there anything I can do to move this along?

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Dec 14, 2016

Is there anything I can do to move this along?

Nope, this is fine.

I just want to give @datalyze-solutions some time to react on this, as they added it initially. If there is no reaction in the short term, very happy to merge this!

cc @datalyze-solutions @kaotika You are aware and OK with this?
By the way, another solution would be that you give @draperjames commit rights to the parent repoif you think that the changes they made in the fork are valuable, but don't have time to maintain it.

@draperjames
Copy link
Author

@jorisvandenbossche I have tried to contact @kaotika and @datalyze-solutions several times over the span of a month with no response. If either entity wanted to to give @zbarge or myself commit rights to the parent we would happily merge our fork with the original repo and help to maintain the project. Thanks for your time.

@jorisvandenbossche jorisvandenbossche merged commit ead784f into pandas-dev:0.19.x Dec 29, 2016
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Dec 29, 2016
@jorisvandenbossche
Copy link
Member

@draperjames waited long enough :-)
BTW, thanks for taking this up!

jorisvandenbossche pushed a commit that referenced this pull request Dec 29, 2016
Just changed the link to the abandoned repository python 2 only pandas-qt to the new functional Python 2/3 friendly qtpandas.
@jorisvandenbossche
Copy link
Member

For some reason this PR was targeting 0.19.x branch instead of master, so applied the same commit on master as well: 0d3ecfa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants