-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
MAINT: Style check *.c and *.h files #14814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Current coverage is 85.28% (diff: 100%)@@ master #14814 diff @@
==========================================
Files 144 144
Lines 50968 50968
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43466 43466
Misses 7502 7502
Partials 0 0
|
"cpplint" was introduced pandas-devgh-14740, and this commit extends to check other *.c and *.h files in the pandas repo. Currently, they all reside in pandas/src, and this commit expands the lint to check all of the following: 1) datetime (dir) 2) ujson (dir) 3) period_helper.c 4) All header files The parser directory was handled in pandas-devgh-14740, and the others have been deliberately omitted.
d276be6
to
27d4d46
Compare
@jreback : Any comments on this? Should be ready to merge. |
lgtm. |
@jorisvandenbossche I think u included the other style in 0.19.2, so can do this as well (up 2 you) |
I didn't include the first style PR for 0.19.2, so for now will do the same for this one. I don't foresee many PRs anymore for 0.19.2, so shouldn't give too much problem |
thanks! |
`cpplint` was introduced pandas-dev#14740, and this commit extends to check other `*.c` and `*.h` files. Currently, they all reside in `pandas/src`, and this commit expands the lint to check all of the following: 1) `datetime` (dir) 2) `ujson` (dir) 3) `period_helper.c` 4) `All header files` The parser directory was handled in pandas-dev#14740, and the others have been deliberately omitted per the discussion <a href="https://github.com/pandas- dev/pandas/pull/14740#issuecomment-265260209">here</a>. Author: gfyoung <[email protected]> Closes pandas-dev#14814 from gfyoung/c-style-continue and squashes the following commits: 27d4d46 [gfyoung] MAINT: Style check *.c and *.h files
any way you can not have the Done processing things show up?
|
cpplint
was introduced #14740, and this commit extends to check other*.c
and*.h
files.Currently, they all reside in
pandas/src
, and this commit expands the lint to check all of the following:datetime
(dir)ujson
(dir)period_helper.c
All header files
The parser directory was handled in #14740, and the others have been deliberately omitted per the discussion here.