Skip to content

MAINT: Style check *.c and *.h files #14814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Dec 7, 2016

cpplint was introduced #14740, and this commit extends to check other *.c and *.h files.

Currently, they all reside in pandas/src, and this commit expands the lint to check all of the following:

  1. datetime (dir)
  2. ujson (dir)
  3. period_helper.c
  4. All header files

The parser directory was handled in #14740, and the others have been deliberately omitted per the discussion here.

@codecov-io
Copy link

codecov-io commented Dec 7, 2016

Current coverage is 85.28% (diff: 100%)

Merging #14814 into master will not change coverage

@@             master     #14814   diff @@
==========================================
  Files           144        144          
  Lines         50968      50968          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43466      43466          
  Misses         7502       7502          
  Partials          0          0          

Powered by Codecov. Last update 2466ecb...27d4d46

"cpplint" was introduced pandas-devgh-14740, and
this commit extends to check other *.c
and *.h files in the pandas repo.

Currently, they all reside in pandas/src,
and this commit expands the lint to check
all of the following:

1) datetime (dir)
2) ujson (dir)
3) period_helper.c
4) All header files

The parser directory was handled in pandas-devgh-14740,
and the others have been deliberately omitted.
@jreback jreback added the Code Style Code style, linting, code_checks label Dec 11, 2016
@gfyoung
Copy link
Member Author

gfyoung commented Dec 14, 2016

@jreback : Any comments on this? Should be ready to merge.

@jreback
Copy link
Contributor

jreback commented Dec 15, 2016

lgtm.

@jreback
Copy link
Contributor

jreback commented Dec 15, 2016

@jorisvandenbossche I think u included the other style in 0.19.2, so can do this as well (up 2 you)

@jreback jreback added this to the 0.19.2 milestone Dec 15, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.2 Dec 15, 2016
@jorisvandenbossche
Copy link
Member

I didn't include the first style PR for 0.19.2, so for now will do the same for this one. I don't foresee many PRs anymore for 0.19.2, so shouldn't give too much problem

@jreback jreback closed this in 358bc6f Dec 15, 2016
@jreback
Copy link
Contributor

jreback commented Dec 15, 2016

thanks!

@gfyoung gfyoung deleted the c-style-continue branch December 15, 2016 16:06
ischurov pushed a commit to ischurov/pandas that referenced this pull request Dec 19, 2016
`cpplint` was introduced pandas-dev#14740, and this commit extends to check
other `*.c` and `*.h` files.    Currently, they all reside in
`pandas/src`, and this commit expands the lint to check all of the
following:    1) `datetime` (dir)  2) `ujson` (dir)  3)
`period_helper.c`  4) `All header files`    The parser directory was
handled in pandas-dev#14740, and the others have been deliberately omitted per
the discussion <a href="https://github.com/pandas-
dev/pandas/pull/14740#issuecomment-265260209">here</a>.

Author: gfyoung <[email protected]>

Closes pandas-dev#14814 from gfyoung/c-style-continue and squashes the following commits:

27d4d46 [gfyoung] MAINT: Style check *.c and *.h files
@jreback
Copy link
Contributor

jreback commented Dec 19, 2016

any way you can not have the Done processing things show up?
we are explicity set to only errors (and which sub-dir) we are handling show up, otherwise its too much text.

linting -> pandas/src/*.h
Done processing pandas/src/numpy_helper.h
Done processing pandas/src/parse_helper.h
Done processing pandas/src/datetime_helper.h
Done processing pandas/src/helper.h
Done processing pandas/src/skiplist.h
Done processing pandas/src/period_helper.h
linting -> pandas/src/period_helper.c
Done processing pandas/src/period_helper.c
linting -> pandas/src/datetime
Done processing pandas/src/datetime/np_datetime_strings.c
Done processing pandas/src/datetime/np_datetime_strings.h
Done processing pandas/src/datetime/np_datetime.h
Done processing pandas/src/datetime/np_datetime.c
linting -> pandas/src/parser
Done processing pandas/src/parser/tokenizer.h
Done processing pandas/src/parser/io.h
Done processing pandas/src/parser/tokenizer.c
Done processing pandas/src/parser/io.c
linting -> pandas/src/ujson
Done processing pandas/src/ujson/python/ujson.c
Done processing pandas/src/ujson/python/JSONtoObj.c
Done processing pandas/src/ujson/python/objToJSON.c
Done processing pandas/src/ujson/lib/ultrajson.h
Done processing pandas/src/ujson/python/version.h
Done processing pandas/src/ujson/lib/ultrajsondec.c

@gfyoung
Copy link
Member Author

gfyoung commented Dec 19, 2016

@jreback : Yes, see #14924.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Style Code style, linting, code_checks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants