Apply min_itemsize to index even when not appending #14812
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toobaz
changed the title
jreback
reviewed
Dec 6, 2016
| @@ -1372,6 +1372,22 @@ def check_col(key, name, size): | |||
| min_itemsize={'index': 4}) | |||
| tm.assert_series_equal(store.select('ss2'), df['B']) | |||
|
|
|||
| # min_itemsize in index of DataFrame.to_hdf() (GH 10381) | |||
There was a problem hiding this comment.
use the existing patter.
don't use store.filename
There was a problem hiding this comment.
OK, replaced with store.put() or .append().
toobaz
force-pushed
the
to_hdf_min_itemsize
branch
from
e5a421e to
cc138d9
Compare
|
can you add a replica of @TomAugspurger example as well (you can make a new test function is fine). Just to cover the bases. |
|
otherwise lgtm. |
toobaz
force-pushed
the
to_hdf_min_itemsize
branch
from
cc138d9 to
fffee0f
Compare
Current coverage is 85.26% (diff: 100%)@@ master #14812 diff @@
==========================================
Files 144 144
Lines 50981 50980 -1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43470 43469 -1
Misses 7511 7511
Partials 0 0
|
toobaz
force-pushed
the
to_hdf_min_itemsize
branch
from
fffee0f to
29a4000
Compare
|
Appveyor is stuck again |
|
rebase again, problem with appeveyor which i just fixed |
toobaz
force-pushed
the
to_hdf_min_itemsize
branch
from
29a4000 to
c07f1e4
Compare
jorisvandenbossche
pushed a commit
that referenced
this pull request
Dec 15, 2016
closes #10381 Author: Pietro Battiston <[email protected]> Closes #14812 from toobaz/to_hdf_min_itemsize and squashes the following commits: c07f1e4 [Pietro Battiston] Whatsnew 38b8fcc [Pietro Battiston] Tests for previous commit c838afa [Pietro Battiston] BUG: set min_itemsize even when there is no need to validate (#10381) (cherry picked from commit e833096)
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
closes pandas-dev#10381 Author: Pietro Battiston <[email protected]> Closes pandas-dev#14812 from toobaz/to_hdf_min_itemsize and squashes the following commits: c07f1e4 [Pietro Battiston] Whatsnew 38b8fcc [Pietro Battiston] Tests for previous commit c838afa [Pietro Battiston] BUG: set min_itemsize even when there is no need to validate (pandas-dev#10381)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff