-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: warning section on memory overflow when joining/merging dataframes on index with duplicate keys #14788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
DOC: warning section on memory overflow when joining/merging dataframes on index with duplicate keys #14788
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
93a63a5
add doc regarding #14736
xgdgsc 795a369
remove blank line
xgdgsc 06d4430
change index to keys , fix spaces and format
xgdgsc fb021fb
fix format
xgdgsc 403b099
add example , change warning position
xgdgsc ee9fc60
fix format
xgdgsc 7581ce0
change fig name, change sentence
xgdgsc 48e5322
remove blank line
xgdgsc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -692,6 +692,30 @@ either the left or right tables, the values in the joined table will be | |
p.plot([left, right], result, | ||
labels=['left', 'right'], vertical=False); | ||
plt.close('all'); | ||
|
||
Here is another example with duplicate join keys in DataFrames: | ||
|
||
.. ipython:: python | ||
|
||
left = pd.DataFrame({'A' : [1,2], 'B' : [2, 2]}) | ||
|
||
right = pd.DataFrame({'A' : [4,5,6], 'B': [2,2,2]}) | ||
|
||
result = pd.merge(left, right, on='B', how='outer') | ||
|
||
.. ipython:: python | ||
:suppress: | ||
|
||
@savefig merging_merge_on_key_multiple.png | ||
p.plot([left, right], result, | ||
labels=['left', 'right'], vertical=False); | ||
plt.close('all'); | ||
|
||
.. warning:: | ||
|
||
Joining / merging on duplicate keys can cause a returned frame that is the multiplication of the row dimensions, | ||
may result in memory overflow, which can be dangerous for unsaved work. | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. remove 'which can be dangerou...' The last sentence should be something like: |
||
Please make sure no duplicate values in keys before joining large DataFrames. | ||
|
||
.. _merging.indicator: | ||
|
||
|
@@ -817,6 +841,7 @@ equivalent: | |
left.join(right, on=key_or_keys) | ||
pd.merge(left, right, left_on=key_or_keys, right_index=True, | ||
how='left', sort=False) | ||
|
||
|
||
Obviously you can choose whichever form you find more convenient. For | ||
many-to-one joins (where one of the DataFrame's is already indexed by the join | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you past the picture in the PR for us to see
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.