ERR: raise on python in object hashing, only supporting strings, nulls #14767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreback
added
Dtype Conversions
|
cc @mikegraham |
|
Awesome, I think this is a really worth while restriction. Thanks! |
|
Initially you were worried about things like tuples for multiindices -- did you decide that wasn't really a concern? |
|
problem with tuples is that they can contain arbitrary things - so punting for now |
strings, nulls xref pandas-dev#14729
jreback
force-pushed
the
hashing_object
branch
from
8fb4ed0 to
9a5a5d4
Compare
Current coverage is 85.27% (diff: 100%)@@ master #14767 diff @@
==========================================
Files 144 144
Lines 50915 50915
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 43418 43418
Misses 7497 7497
Partials 0 0
|
jreback
added a commit
to jreback/pandas
that referenced
this pull request
Dec 6, 2016
jreback
added a commit
that referenced
this pull request
Dec 6, 2016
* BUG: we don't like hash collisions in siphash xref #14767 * This should be a 64-bit int, not an 8-bit int * fix tests
jorisvandenbossche
pushed a commit
that referenced
this pull request
Dec 15, 2016
…ting strings, nulls xref #14729 Author: Jeff Reback <[email protected]> Closes #14767 from jreback/hashing_object and squashes the following commits: 9a5a5d4 [Jeff Reback] ERR: raise on python in object hashing, only supporting strings, nulls (cherry picked from commit de1132d)
jorisvandenbossche
pushed a commit
that referenced
this pull request
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #14729