TST: Same return values in drop_duplicates for Series and DataFrames(#… #14754
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
changed the title
sinhrks
added
Missing-data
Current coverage is 85.24% (diff: 100%)
|
sinhrks
suggested changes
Dec 1, 2016
| # GH 14192 | ||
| df = pd.DataFrame({'a': [1, 1, 1, 'one', 'one'], | ||
| 'b': [2, 2, np.nan, np.nan, np.nan], | ||
| 'c': [3, 3, np.nan, np.nan, 'three'] |
There was a problem hiding this comment.
can u also add int and datetime64(with NaT) columns to be comprehensive?
There was a problem hiding this comment.
Sure thing. Will add those columns tonight.
sinhrks
suggested changes
Dec 1, 2016
| 'c': [3, 3, np.nan, np.nan, 'three'] | ||
| }) | ||
| for column in df.columns: | ||
| dropped_frame = df[[column]].drop_duplicates() |
There was a problem hiding this comment.
pls loop with keep patterns also.
There was a problem hiding this comment.
Sure thing, will include the keep kwarg.
…andas-dev#14192) Add keep kwarg and new columns
|
Added the |
sinhrks
approved these changes
Dec 4, 2016
|
@mroeschke Thanks! |
ischurov
pushed a commit
to ischurov/pandas
that referenced
this pull request
Dec 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff…14192)