CLN: move assignment from header into cython #14731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 85.21% (diff: 100%)@@ master #14731 diff @@
==========================================
Files 143 143
Lines 50804 50804
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43292 43293 +1
+ Misses 7512 7511 -1
Partials 0 0
|
jreback
reviewed
Nov 25, 2016
| @@ -7,11 +7,6 @@ | |||
| #define PyInt_AS_LONG PyLong_AsLong | |||
| #endif | |||
|
|
|||
| void mangle_nat(PyObject *val) { | |||
There was a problem hiding this comment.
this also has a reference in datetime.pxd (can remove this too)
|
@jreback thanks, fixed |
|
thanks @mattip |
jorisvandenbossche
pushed a commit
that referenced
this pull request
Dec 15, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
an insignificant refactoring that allows PyPy2.7 to build and import Pandas. The original code uses functions that are macros in CPython but actual c-functions in PyPy and one cannot assign to a function result
Note that while PyPy imports Pandas, it very quickly segfaults, Apparently PyPy does not yet play well with enough of Cython, I suspect strange interactions with tp_new and tp_deallocate