Skip to content

MAINT: Ignore .pxi files #14723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

gfyoung
Copy link
Member

@gfyoung gfyoung commented Nov 23, 2016

All .pxi files have the warning to not edit directly, so why not have Git ignore any changes made there?

In addition, this PR deletes all of the .pxi files from the codebase because they are automatically generated by the .pxi.in files

@jreback
Copy link
Contributor

jreback commented Nov 23, 2016

if you did this and don't check them in.

the a new clone & build will generate them, so that's ok.

when you change a .in they will get regenerated, so that seems ok.

when you switch branches what happens? (e.g. modify something in a .in in one branch), switch to another
make should just regen the files you need. does that work?

@jreback jreback added the Build Library building on various platforms label Nov 23, 2016
@gfyoung
Copy link
Member Author

gfyoung commented Nov 23, 2016

@jreback : Yes, it does.

@jreback
Copy link
Contributor

jreback commented Nov 23, 2016

ok so in this PR, remove all of the .pxi as well.

@codecov-io
Copy link

codecov-io commented Nov 23, 2016

Current coverage is 85.21% (diff: 100%)

Merging #14723 into master will increase coverage by <.01%

@@             master     #14723   diff @@
==========================================
  Files           143        143          
  Lines         50804      50804          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43292      43293     +1   
+ Misses         7512       7511     -1   
  Partials          0          0          

Powered by Codecov. Last update 75b606a...fe0c410

@gfyoung gfyoung force-pushed the gitignore-pxi-ignore branch 3 times, most recently from 1a6d705 to 4b034fd Compare November 24, 2016 03:56
@gfyoung
Copy link
Member Author

gfyoung commented Nov 24, 2016

Travis OSX keeps breaking because it cannot seem to hit the github.com endpoint when cloning the repository, which is unrelated to this PR. Silencing testing for now until that resolves itself.

@jorisvandenbossche
Copy link
Member

cc @sinhrks @chris-b1

@gfyoung gfyoung force-pushed the gitignore-pxi-ignore branch from 4b034fd to 77ec721 Compare November 24, 2016 17:00
@gfyoung
Copy link
Member Author

gfyoung commented Nov 24, 2016

@jreback , @jorisvandenbossche : Travis is behaving again, so this should be ready to merge.

@jreback
Copy link
Contributor

jreback commented Nov 24, 2016

can you confirm that that travis caching still works?

@sinhrks
Copy link
Member

sinhrks commented Nov 24, 2016

I've added these files only for travis caching, so it's good to remove if caching can still work.

Add .pxi to .gitignore and delete
all .pxi files from the codebase.
@gfyoung gfyoung force-pushed the gitignore-pxi-ignore branch from 77ec721 to fe0c410 Compare November 25, 2016 04:52
@gfyoung
Copy link
Member Author

gfyoung commented Nov 25, 2016

@sinhrks , @jreback : I don't see any issues with caching on Travis, so I think this should be good to go.

@jreback jreback closed this in ee10816 Nov 25, 2016
@jreback jreback added this to the 0.19.2 milestone Nov 25, 2016
@jreback
Copy link
Contributor

jreback commented Nov 25, 2016

thanks!

@jreback
Copy link
Contributor

jreback commented Nov 25, 2016

let's keep an eye on the caching though

@gfyoung gfyoung deleted the gitignore-pxi-ignore branch November 25, 2016 17:11
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.2 Nov 25, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.19.2, 0.20.0 Dec 15, 2016
jorisvandenbossche pushed a commit that referenced this pull request Dec 15, 2016
All `.pxi` files have the warning to not edit directly, so why not
have Git ignore any changes made there?    In addition, this PR
deletes all of the `.pxi` files from the codebase because they are
automatically generated by the `.pxi.in` files

Author: gfyoung <[email protected]>

Closes #14723 from gfyoung/gitignore-pxi-ignore and squashes the following commits:

fe0c410 [gfyoung] MAINT: Ignore .pxi files

(cherry picked from commit ee10816)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build Library building on various platforms
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants