-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
MAINT: Ignore .pxi files #14723
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Ignore .pxi files #14723
Conversation
if you did this and don't check them in. the a new clone & build will generate them, so that's ok. when you change a when you switch branches what happens? (e.g. modify something in a .in in one branch), switch to another |
@jreback : Yes, it does. |
ok so in this PR, remove all of the .pxi as well. |
Current coverage is 85.21% (diff: 100%)@@ master #14723 diff @@
==========================================
Files 143 143
Lines 50804 50804
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43292 43293 +1
+ Misses 7512 7511 -1
Partials 0 0
|
1a6d705
to
4b034fd
Compare
Travis OSX keeps breaking because it cannot seem to hit the |
4b034fd
to
77ec721
Compare
@jreback , @jorisvandenbossche : Travis is behaving again, so this should be ready to merge. |
can you confirm that that travis caching still works? |
I've added these files only for travis caching, so it's good to remove if caching can still work. |
Add .pxi to .gitignore and delete all .pxi files from the codebase.
77ec721
to
fe0c410
Compare
thanks! |
let's keep an eye on the caching though |
All `.pxi` files have the warning to not edit directly, so why not have Git ignore any changes made there? In addition, this PR deletes all of the `.pxi` files from the codebase because they are automatically generated by the `.pxi.in` files Author: gfyoung <[email protected]> Closes #14723 from gfyoung/gitignore-pxi-ignore and squashes the following commits: fe0c410 [gfyoung] MAINT: Ignore .pxi files (cherry picked from commit ee10816)
All
.pxi
files have the warning to not edit directly, so why not have Git ignore any changes made there?In addition, this PR deletes all of the
.pxi
files from the codebase because they are automatically generated by the.pxi.in
files