Skip to content

ERR: fix exception propogation for datetime parsing functions, noted in python 3.6 #14678

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

ERR: fix exception propogation for datetime parsing functions, noted in python 3.6 #14678

wants to merge 1 commit into from

Conversation

jreback
Copy link
Contributor

@jreback jreback commented Nov 17, 2016

closes #14561

@jreback jreback added the Compat pandas objects compatability with Numpy or Python functions label Nov 17, 2016
@jreback jreback added this to the 0.19.2 milestone Nov 17, 2016
@jreback
Copy link
Contributor Author

jreback commented Nov 17, 2016

so after this PR: https://travis-ci.org/jreback/pandas/jobs/176738690

get a small number of failures (and bunch of deprecation warnings). but looks like this fixes the xref issue.

@jreback jreback mentioned this pull request Nov 17, 2016
Closed
@jreback jreback closed this in b52dda8 Nov 17, 2016
@jorisvandenbossche
Copy link
Member

@jreback Thanks!

Just a question, what is the reason for the change in setup.py?

@jreback
Copy link
Contributor Author

jreback commented Nov 17, 2016

changes to that file (.pxd) were not in the build chain - it's a dependency so should have been

jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Dec 14, 2016
@jreback @jorisvandenbossche
[Backport pandas-dev#14678] ERR: fix exception propogation for dateti…
ef91dcc 
…me parsing functions, noted in python 3.6

closes pandas-dev#14561

Author: Jeff Reback <[email protected]>

Closes pandas-dev#14678 from jreback/py3.6_fix and squashes the following commits:

c8eed83 [Jeff Reback] ERR: fix exception propogation for datetime parsing functions, noted in python 3.6

(cherry picked from commit b52dda8)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.

Invalid datetime string conversion giving SystemError with Python 3.6.0b3
2 participants
@jreback @jorisvandenbossche