Skip to content

TST: Test aggregation over arrays (#3788) #14675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mroeschke
Copy link
Member

@jreback jreback added Groupby Testing pandas testing functions or related to the test suite labels Nov 17, 2016
@jreback
Copy link
Contributor

jreback commented Nov 17, 2016

you are picking up the commit for the pivot table PR. this should be separate

@TomAugspurger
Copy link
Contributor

@mroeschke specifically, the workflow should be

  • sync your master with upstream git fetch upstream; git rebase upstream/master from your master branch
  • checkout a new branch for each change git co -b array-agg

You should just be able to git rebase -i upstream/master and delete the commit with the pivot table changes and force push.

@mroeschke
Copy link
Member Author

Ah didn't notice this picked up the commit from my other PR. Thanks for the guidance! I'll decouple it later tonight.

@codecov-io
Copy link

codecov-io commented Nov 18, 2016

Current coverage is 85.21% (diff: 100%)

Merging #14675 into master will increase coverage by <.01%

@@             master     #14675   diff @@
==========================================
  Files           143        143          
  Lines         50787      50787          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43273      43276     +3   
+ Misses         7514       7511     -3   
  Partials          0          0          

Powered by Codecov. Last update f26b049...01dce9d

@mroeschke
Copy link
Member Author

mroeschke commented Nov 18, 2016

I checked out the travis-ci build logs and it doesn't look like my change directly caused the build to fail (to my knowledge). Is there anything I need to address on my end?

EDIT: Reran the tests, and they are now passing

@jreback jreback added this to the 0.19.2 milestone Nov 22, 2016
@jreback
Copy link
Contributor

jreback commented Nov 22, 2016

thanks!

@jreback jreback closed this in 3443de7 Nov 22, 2016
@jorisvandenbossche jorisvandenbossche modified the milestones: 0.20.0, 0.19.2 Dec 14, 2016
@mroeschke mroeschke deleted the fix_3788 branch December 20, 2017 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Groupby Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Aggregating over arrays
5 participants