Skip to content

BUG: Columns and Index share the same numpy object underneath when pd.DataFrame.cov is used #14667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

kapilsh
Copy link

@kapilsh kapilsh commented Nov 16, 2016

Index now copies the columns array instead of using the same object in
covariance and correlations stats methods of dataframe
@jreback jreback changed the title Updates for Bug #14617 BUG: Columns and Index share the same numpy object underneath when pd.DataFrame.cov is used Nov 16, 2016
@jreback jreback added Bug Indexing Related to indexing on series/frames, not to indexes themselves Numeric Operations Arithmetic, Comparison, and Logical operations labels Nov 16, 2016
@jreback
Copy link
Contributor

jreback commented Nov 16, 2016

  • needs tests; you can put next to the other .cov tests
  • add a whatsnew note in 0.19.2

@codecov-io
Copy link

codecov-io commented Nov 16, 2016

Current coverage is 85.28% (diff: 100%)

Merging #14667 into master will increase coverage by <.01%

@@             master     #14667   diff @@
==========================================
  Files           140        140          
  Lines         50693      50695     +2   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43234      43236     +2   
  Misses         7459       7459          
  Partials          0          0          

Powered by Codecov. Last update 3f523f3...428cb37

@jreback
Copy link
Contributor

jreback commented Dec 21, 2016

can you update (whatsnew in 0.20.0)

@jreback
Copy link
Contributor

jreback commented Dec 30, 2016

can you add a test and whatsnew for 0.20.0 (bug fix)

@jreback
Copy link
Contributor

jreback commented Feb 27, 2017

closing as stale. please ping if you'd like to continue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Indexing Related to indexing on series/frames, not to indexes themselves Numeric Operations Arithmetic, Comparison, and Logical operations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Columns and Index share the same numpy object underneath when pd.DataFrame.cov is used
4 participants