COMPAT: Cast to string before raise in read_stata #14657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in `pandas.io.stata::StataReader::_read_old_hearder` we try to raise a ValueError. I'm working on making a test, but this is buried pretty deep. For now, `typlist` has type `List[int]`. We call ```python ','.join(typlist) ``` which errors on py3.
|
I canceled the CI builds since there aren't any new tests (yet) |
|
Looking further, @PKEuS would have added originally in kshedden@87d41f3#diff-2def41db3b4d04fb64de8313c0e6c25eR380 (the highlighted line had the necessary @jreback any objections to merging this as-is (without any tests). I've verified that our current test suite doesn't touch these lines, so I'm not making anything worse 😆 |
|
lgtm. |
jreback
added
the
Compat
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Dec 14, 2016
…ad_stata (pandas-dev#14657) Fix ValueError message in StataReader Cast to string before joining the list of typecodes in the error message. (cherry picked from commit 1606153)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
pandas.io.stata::StataReader::_read_old_headerwetry to raise a ValueError.
I'm working on making a test, but this is buried pretty deep.
For now,
typlisthas typeList[int]. We callwhich errors on py3 (and python 2 I guess?). This came up in #13856, see https://travis-ci.org/pandas-dev/pandas/jobs/175705122#L1284 for the failure.
@kshedden any memory of writing this code? This is a bare
exceptbut it looks like the only exception that would trigger this is anIndexErrorwhen something intyplistis out of bounds onself.TYPE_MAP. Any hints on writing a test to exercise this code? If not I'll dig in more tonight.