Skip to content

DOC: Update Series.mode docstring #14653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

scajanus
Copy link

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • whatsnew entry

Series mode method does not support sort parameter, even though the documentation says so. Neither does the underlying function from pandas.core.algorithms.

@codecov-io
Copy link

codecov-io commented Nov 14, 2016

Current coverage is 85.28% (diff: 100%)

Merging #14653 into master will not change coverage

@@             master     #14653   diff @@
==========================================
  Files           140        140          
  Lines         50693      50693          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits          43234      43234          
  Misses         7459       7459          
  Partials          0          0          

Powered by Codecov. Last update 1d6dbb4...0d250c2

@jorisvandenbossche
Copy link
Member

jorisvandenbossche commented Nov 14, 2016

@sakkemo Thanks for the PR!

This was added in the original PR that added the mode method, but this indeed does not really seem to be correct (#5380). Possibly the return values will be sorted if there are multiple return values?

@scajanus
Copy link
Author

scajanus commented Nov 14, 2016

Yes, the return values are sorted! It says so in the return value part of the docstring (hidden by the fold in github by default), but perhaps it could be added in the description as well.

     Returns
     -------
     modes : Series (sorted)

Regarding the list at the top, do I need to add an issue? Also I didn't know to which whatsnew file add the changes, 0.19.2 or 0.20.0. It depends on when this is merged, of course.

@jorisvandenbossche jorisvandenbossche merged commit 3f523f3 into pandas-dev:master Nov 15, 2016
@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Nov 15, 2016
@jorisvandenbossche
Copy link
Member

@sakkemo Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants