Skip to content

Fix trailing current date zeros flaky test_format problem #14638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

Fix trailing current date zeros flaky test_format problem #14638

wants to merge 2 commits into from

Conversation

MykolaGolubyev
Copy link
Contributor

jreback
jreback requested changes Nov 11, 2016
View reviewed changes
pandas/tests/indexes/test_base.py
@@ -937,6 +937,15 @@ def test_format(self):

self.strIndex[:0].format()

# GH 14626
def datetime_now_without_trailing_zeros(self):
now = datetime.now()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

so put this inside the other function (as it's just used there)

@jreback jreback added this to the 0.19.2 milestone Nov 12, 2016
@jreback jreback added the Testing pandas testing functions or related to the test suite label Nov 12, 2016
@jreback jreback closed this in 3552dc0 Nov 12, 2016
@jreback
Copy link
Contributor

jreback commented Nov 12, 2016

thanks!

jorisvandenbossche pushed a commit to jorisvandenbossche/pandas that referenced this pull request Dec 14, 2016
@MykolaGolubyev @jorisvandenbossche
TST: Fix trailing current date zeros flaky test_format problem
ba35ea9 
closes pandas-dev#14626

Author: Mykola Golubyev <[email protected]>

Closes pandas-dev#14638 from MykolaGolubyev/issue-14626 and squashes the following commits:

166ec23 [Mykola Golubyev] Inline datetime_now_without_trailing_zeros within test_format
68a72a7 [Mykola Golubyev] Fix trailing current date zeros flaky test_format problem

(cherry picked from commit 3552dc0)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jreback jreback jreback requested changes

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
0.19.2
Development

Successfully merging this pull request may close these issues.

TST: indexes/test_base.py:TestIndex.test_format is flaky
2 participants
@MykolaGolubyev @jreback