Skip to content

Update GitHub org from pydata to pandas-dev #14575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 4, 2016

Conversation

dhimmel
Copy link
Contributor

@dhimmel dhimmel commented Nov 3, 2016

It looks like the repo moved owners from pydata to pandas-dev. This pull request updates the repository to refer to pandas-dev/pandas rather than pydata/pandas.

  • passes git diff upstream/master | flake8 --diff
  • tests added / passed
  • whatsnew entry

@dhimmel
Copy link
Contributor Author

dhimmel commented Nov 3, 2016

I didn't replace the following two URLs:

I did replace what's new URLs -- not sure if "what's new" files should be immutable after release?

@@ -143,7 +143,7 @@ both "column wise min/max and global min/max coloring."
API
-----

`pandas-datareader <https://github.com/pydata/pandas-datareader>`__
`pandas-datareader <https://github.com/pandas-dev/pandas-datareader>`__
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is still in pydata

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 2368761

@@ -1,6 +1,6 @@
raise ImportError(
"The pandas.io.wb module is moved to a separate package "
"(pandas-datareader). After installing the pandas-datareader package "
"(https://github.com/pandas-dev/pandas-datareader), you can change "
"(https://github.com/pydata/pandas-datareader), you can change "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@@ -1,6 +1,6 @@
raise ImportError(
"The pandas.io.data module is moved to a separate package "
"(pandas-datareader). After installing the pandas-datareader package "
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@@ -13,7 +13,7 @@ DataReader

The sub-package ``pandas.io.data`` is removed in favor of a separately
installable `pandas-datareader package
<https://github.com/pandas-dev/pandas-datareader>`_. This will allow the data
<https://github.com/pydata/pandas-datareader>`_. This will allow the data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remote this

@@ -27,7 +27,7 @@ about it!

Feel free to ask questions on the `mailing list
<https://groups.google.com/forum/?fromgroups#!forum/pydata>`_ or on `Gitter
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove this

@jreback
Copy link
Contributor

jreback commented Nov 3, 2016

@dhimmel there are only very very few changes remaining, you are adding files that are already deleted

@dhimmel
Copy link
Contributor Author

dhimmel commented Nov 3, 2016

you are adding files that are already deleted

@jreback sorry I'm confused. I didn't think I was adding any new files? Where have they been deleted?

Do you also want me to doc updates, like removing the Google Group Mailing List link? That seems unrelated to this PR, but I'm happy to make those changes here if desired.

@jreback
Copy link
Contributor

jreback commented Nov 3, 2016

looks at the changes, some were changed from pandas-dev TO pydata (and not the reverse)

@jorisvandenbossche
Copy link
Member

@jreback The ones that are changed back to pydata, are the pandas-datareader ones, so it is correct to change this back

@dhimmel
Copy link
Contributor Author

dhimmel commented Nov 3, 2016

@jreback see #14575 (comment): pandas-datareader is still hosted at pydata.

looks at the changes, some were changed from pandas-dev TO pydata (and not the reverse)

Check the diff for the entire PR.

@jorisvandenbossche jorisvandenbossche added this to the 0.20.0 milestone Nov 3, 2016
@codecov-io
Copy link

Current coverage is 85.27% (diff: 100%)

Merging #14575 into master will increase coverage by <.01%

@@             master     #14575   diff @@
==========================================
  Files           140        140          
  Lines         50693      50693          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43229      43230     +1   
+ Misses         7464       7463     -1   
  Partials          0          0          

Powered by Codecov. Last update e1cdc4b...2368761

@jorisvandenbossche jorisvandenbossche merged commit 7a2bcb6 into pandas-dev:master Nov 4, 2016
@jorisvandenbossche
Copy link
Member

Thanks @dhimmel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants