BUG: Fix justification for DataFrame.to_string(index=False) #14569
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
did the soln in #14196 not work? |
Current coverage is 85.27% (diff: 100%)@@ master #14569 diff @@
==========================================
Files 140 140
Lines 50693 50691 -2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
- Hits 43230 43227 -3
- Misses 7463 7464 +1
Partials 0 0
|
|
I tried to make some updates to that other PR over at this branch, but there are a large number of test failures due to the change in functionality. I haven't had a chance to figure out which failures are simply due to out-of-date test cases, as opposed to newly-introduced bugs. On another note, I realized that my changes in this PR should only apply to cases where the first column is numeric. I've added some new commits to this branch to try to address this, but unfortunately this seems significantly more fragile. I can see why a more comprehensive fix like PR #14196 would be preferable. |
|
@buggi22 can you rebase / update? |
|
closing as stale |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this fixes #13032. I'm a new contributor, so please let me know if I've missed any steps.