ENH: Added optional pickle protocol version argument to pandas.to_pickle() #14526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1200,7 +1200,7 @@ def to_sql(self, name, con, flavor=None, schema=None, if_exists='fail', | |||
| if_exists=if_exists, index=index, index_label=index_label, | |||
| chunksize=chunksize, dtype=dtype) | |||
|
|
|||
| def to_pickle(self, path): | |||
| def to_pickle(self, path, protocol): | |||
There was a problem hiding this comment.
protocol should be an optional argument here. You'll probably need to have the default be None, and then determine the correct protocol based on the python version (see pandas.compat). The default should be the same as python's default.
There was a problem hiding this comment.
Actually HIGHEST_PROTOCOL should work I think.
|
can you rebase |
jreback
added
API Design
Compat
|
closing as stale, but if you would like to update, pls comment. |
|
If the original author @beverast lost interest in the PR, I would like to take over. |
|
sure u can start with the commits here if u like |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diff… :issue:'14488'