-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
BUG: to_numeric downcast = 'unsigned' would not un-sign a 0 value. #14504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
16 commits
Select commit
Hold shift + click to select a range
d530db0
Made it so that 0 was included in uint8
f3bdcdc
Added a test to check uint8 with 0
180d0ec
Added release note to issue 14401 resolve.
4794ca6
Added tests for the max and min values of all dtypes to to_numeric
058697f
Changed the tests so that it iterated through a dictionary.
5a7457a
Changed the test to work with python 3.x
5ae5066
Made the dictionaries into one list of sets.
615c16a
Did some editing for some lint problems.
7940a04
Revert "Added release note to issue 14401 resolve."
8da173b
Made the downcast limits test its own function.
a64c5ab
Screwed up the issue tracker again
100fe4a
Fixed the lint issues.
8685112
Added a test to make sure numpy is new enough.
90eef20
Added correct version test and changed whatsnew
5fc9976
Added comments and edited the whatsnew.
07264cd
Revert
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
put a comment on why skipping the
uint64