Use old Cython build_ext until includes are fixed. #14496
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change The distutils extension Cython.Distutils.build_ext has now been updated to use cythonize which properly handles dependencies. The old extension can still be found in Cython.Distutils.old_build_ext and is now deprecated. in Cython 0.25 seems to have broken includes. As a temporary workaround, the old build_ext can be used.
|
It looks like the difficulties are due to
|
jreback
requested changes
Oct 26, 2016
| @@ -85,7 +85,7 @@ def is_platform_mac(): | |||
| try: | |||
| if not _CYTHON_INSTALLED: | |||
| raise ImportError('No supported version of Cython installed.') | |||
| from Cython.Distutils import build_ext as _build_ext | |||
There was a problem hiding this comment.
well that will fail on older versions of cython wouldn't it?
need to check in a try except
further we use older (and newer versions) of cython in various builds
Current coverage is 85.26% (diff: 100%)@@ master #14496 diff @@
==========================================
Files 140 140
Lines 50667 50670 +3
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43203 43205 +2
- Misses 7464 7465 +1
Partials 0 0
|
|
lgtm. can you add a release note, say compat with cython 0.25 builds. was just about to say this isn't tested on travis, but cython JUST updated and broke our builds :> |
|
so going to merge. thanks! |
jreback
approved these changes
Oct 26, 2016
|
I fixed the 3.4 build on the most recent cython. 6ac759d If you would like to submit a PR to actually fix the way cython builds for >= 0.25 would be great! (need compat of course for older cythons). We still support >= 0.19.1, but should prob move that up. |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Nov 2, 2016
closes pandas-dev#14496 (cherry picked from commit 66b4c83)
yarikoptic
added a commit
to neurodebian/pandas
that referenced
this pull request
Nov 18, 2016
Version 0.19.1 * tag 'v0.19.1': (43 commits) RLS: v0.19.1 DOC: update whatsnew/release notes for 0.19.1 (pandas-dev#14573) [Backport pandas-dev#14545] BUG/API: Index.append with mixed object/Categorical indices (pandas-dev#14545) DOC: rst fixes [Backport pandas-dev#14567] DEPR: add deprecation warning for com.array_equivalent (pandas-dev#14567) [Backport pandas-dev#14551] PERF: casting loc to labels dtype before searchsorted (pandas-dev#14551) [Backport pandas-dev#14536] BUG: DataFrame.quantile with NaNs (GH14357) (pandas-dev#14536) [Backport pandas-dev#14520] BUG: don't close user-provided file handles in C parser (GH14418) (pandas-dev#14520) [Backport pandas-dev#14392] BUG: Dataframe constructor when given dict with None value (pandas-dev#14392) [Backport pandas-dev#14514] BUG: Don't parse inline quotes in skipped lines (pandas-dev#14514) [Bacport pandas-dev#14543] BUG: tseries ceil doc fix (pandas-dev#14543) [Backport pandas-dev#14541] DOC: Simplify the gbq integration testing procedure for contributors (pandas-dev#14541) [Backport pandas-dev#14527] BUG/ERR: raise correct error when sql driver is not installed (pandas-dev#14527) [Backport pandas-dev#14501] BUG: fix DatetimeIndex._maybe_cast_slice_bound for empty index (GH14354) (pandas-dev#14501) [Backport pandas-dev#14442] DOC: Expand on reference docs for read_json() (pandas-dev#14442) BLD: fix 3.4 build for cython to 0.24.1 [Backport pandas-dev#14492] BUG: Accept unicode quotechars again in pd.read_csv [Backport pandas-dev#14496] BLD: Support Cython 0.25 [Backport pandas-dev#14498] COMPAT/TST: fix test for range testing of negative integers to neg powers [Backport pandas-dev#14476] PERF: performance regression in Series.asof (pandas-dev#14476) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change in Cython 0.25
The distutils extension Cython.Distutils.build_ext has now been updated to use cythonize which properly handles dependencies. The old extension can still be found in Cython.Distutils.old_build_ext and is now deprecated.
seems to have broken the include of auto-generated algos_common_helper.pxi. As a temporary workaround, the old build_ext can be used.