BUG: Set frequency for empty Series #14458

sahildua2305 · 2016-10-19T23:36:04Z

closes BUG: Frequency not set for empty Series #14320
tests added / passed
passes git diff upstream/master | flake8 --diff
whatsnew entry

Alternative to #14340

sinhrks · 2016-10-20T01:08:17Z

pandas/tests/frame/test_timeseries.py

+        empty = Series(index=pd.DatetimeIndex([])).asfreq('H')
+        normal = Series(index=pd.DatetimeIndex(["2016-09-29 11:00"]),
+                        data=[3]).asfreq('H')
+        self.assertEqual(empty.index.freq, normal.index.freq)


can u also test for TimedeltaIndex and PeriodIndex? The latter looks work properly, but for assurance.

call these empty -> expected and normal -> result

use assert_index_equal to compare

@sinhrks should I add assert it for these types of indices in the same test or should I create separate tests for them?

can u add to tserirs/tests/test_period(timedelras)?

codecov-io · 2016-10-20T02:25:56Z

Codecov Report

Merging #14458 into master will decrease coverage by -0.03%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master   #14458      +/-   ##
==========================================
- Coverage   91.04%   91.02%   -0.03%     
==========================================
  Files         136      136              
  Lines       49088    49091       +3     
==========================================
- Hits        44694    44685       -9     
- Misses       4394     4406      +12

Impacted Files	Coverage Δ
pandas/tseries/resample.py	`94.5% <100%> (+0.02%)`	✅
pandas/io/gbq.py	`25% <0%> (-58.34%)`	❌
pandas/tools/merge.py	`91.78% <0%> (-0.35%)`	❌
pandas/util/testing.py	`81.87% <0%> (-0.19%)`	❌
pandas/core/frame.py	`97.82% <0%> (-0.1%)`	❌
pandas/core/common.py	`91.36% <0%> (+0.33%)`	✅

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 211ecd5...384e666. Read the comment docs.

jorisvandenbossche · 2016-10-30T18:01:01Z

doc/source/whatsnew/v0.19.1.txt

+  is not scalar and ``values`` is not specified (:issue:`14380`)
+- Bug in ``pd.pivot_table`` may raise ``TypeError`` or ``ValueError`` when ``index`` or ``columns``


You repeated here the previous entry

can you move to 0.20.0

jorisvandenbossche · 2016-10-30T18:02:21Z

pandas/tests/frame/test_timeseries.py

+        expected = Series(index=pd.DatetimeIndex(
+            ["2016-09-29 11:00"])).asfreq('H')
+        result = Series(index=pd.DatetimeIndex(["2016-09-29 11:00"]),
+                        data=[3]).asfreq('H')


Can you create one of the two without using asfreq.

Further, it is not fully clear what is what you actually testing, as the result of the empty series is called expected (you typically call the constructed expected value expected to compare the result of what you want to test)

@jorisvandenbossche Actually the issue was that we didn't set frequency properly for empty series. Hence I'm testing this particular thing by comparing with frequency of a non-empty Series that we make using similar parameters with an empty one.

jorisvandenbossche · 2016-11-11T09:37:32Z

@sahildua2305 Can you update?

sahildua2305 · 2016-11-11T15:34:40Z

Got busy with stuff. I will update this soon @jorisvandenbossche

jreback · 2016-12-16T23:58:59Z

can you rebase / update

sahildua2305 · 2016-12-19T11:24:08Z

Yes, will do!

jreback · 2016-12-20T13:53:04Z

pandas/tests/frame/test_timeseries.py

+        result = Series(index=pd.DatetimeIndex(["2016-09-29 11:00"]),
+                        data=[3]).asfreq('H')
+        self.assert_index_equal(expected.index, result.index)
+


compare the series, e.g. assert_series_equal, and construct the expected directly.

you have two results to compare here, what you currently have labeled as expected and as result.

make another tests where you construct the expected directly (iow, dont' use .asfreq) . IOW you actually should use a direc

jreback · 2016-12-20T13:53:16Z

pandas/tseries/tests/test_period.py

@@ -1596,6 +1596,14 @@ def test_asfreq_mult(self):
            self.assertEqual(result.ordinal, expected.ordinal)
            self.assertEqual(result.freq, expected.freq)

+    def test_asfreq_period_empty_series(self):
+        # GH 14340
+        expected = Series(index=pd.PeriodIndex(['2011-1', '2011-2', '2011-3'],


same here as above

jreback · 2016-12-30T21:26:30Z

can you rebase / update

jreback · 2017-02-27T16:03:54Z

can you rebase / update

Add test to verify frequency for empty series Update 0.19.1 whatsnew doc Fix linting; exceeded number of characters on one line Improve tests, add assertion for PeriodIndex as well Refactor tests and move to correct file Move changelog entry from 0.19.1 to 0.20.0

jreback · 2017-03-03T13:16:20Z

thanks!

closes pandas-dev#14320 Author: Sahil Dua <[email protected]> Closes pandas-dev#14458 from sahildua2305/frequency-series-fix and squashes the following commits: 384e666 [Sahil Dua] BUG: Set frequency for empty Series

sinhrks reviewed Oct 20, 2016

View reviewed changes

sinhrks added Bug Frequency DateOffsets labels Oct 20, 2016

sinhrks added this to the 0.19.1 milestone Oct 20, 2016

sahildua2305 force-pushed the frequency-series-fix branch 2 times, most recently from 0bb68de to 6d95b3a Compare October 28, 2016 15:18

jorisvandenbossche reviewed Oct 30, 2016

View reviewed changes

jorisvandenbossche modified the milestones: 0.20.0, 0.19.1 Nov 1, 2016

sahildua2305 force-pushed the frequency-series-fix branch from f5e2400 to f39a1bc Compare December 19, 2016 22:39

jreback reviewed Dec 20, 2016

View reviewed changes

sahildua2305 force-pushed the frequency-series-fix branch from f39a1bc to 1494d85 Compare January 4, 2017 13:12

sahildua2305 force-pushed the frequency-series-fix branch from 1494d85 to 384e666 Compare March 2, 2017 23:55

jreback closed this in 0b07b07 Mar 3, 2017

sahildua2305 deleted the frequency-series-fix branch March 3, 2017 13:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

BUG: Set frequency for empty Series #14458

BUG: Set frequency for empty Series #14458

sahildua2305 commented Oct 19, 2016

sinhrks Oct 20, 2016 •

edited

Loading

jreback Oct 20, 2016

sahildua2305 Oct 22, 2016

sinhrks Oct 23, 2016

codecov-io commented Oct 20, 2016 •

edited

Loading

jorisvandenbossche Oct 30, 2016

jreback Dec 16, 2016

sahildua2305 Dec 19, 2016

jorisvandenbossche Oct 30, 2016

sahildua2305 Dec 19, 2016

jorisvandenbossche commented Nov 11, 2016

sahildua2305 commented Nov 11, 2016

jreback commented Dec 16, 2016

sahildua2305 commented Dec 19, 2016

jreback Dec 20, 2016

jreback Dec 20, 2016

jreback commented Dec 30, 2016

jreback commented Feb 27, 2017

jreback commented Mar 3, 2017

		is not scalar and ``values`` is not specified (:issue:`14380`)
		- Bug in ``pd.pivot_table`` may raise ``TypeError`` or ``ValueError`` when ``index`` or ``columns``

BUG: Set frequency for empty Series #14458

BUG: Set frequency for empty Series #14458

Conversation

sahildua2305 commented Oct 19, 2016

sinhrks Oct 20, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 20, 2016 • edited Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jorisvandenbossche commented Nov 11, 2016

sahildua2305 commented Nov 11, 2016

jreback commented Dec 16, 2016

sahildua2305 commented Dec 19, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jreback commented Dec 30, 2016

jreback commented Feb 27, 2017

jreback commented Mar 3, 2017

sinhrks Oct 20, 2016 •

edited

Loading

codecov-io commented Oct 20, 2016 •

edited

Loading