DOC:updated docstring in .to_datetime() #14452
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
keshavramaswamy
commented
Oct 19, 2016
•
keshavramaswamy
commented
- closes DOC/BUG: pd.to_datetime example produces different results from documentation #14448
- tests added / passed
- passes git diff upstream/master | flake8 --diff
- whatsnew entry
keshavramaswamy
changed the title
Current coverage is 85.25% (diff: 100%)@@ master #14452 diff @@
==========================================
Files 140 140
Lines 50631 50655 +24
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43166 43185 +19
- Misses 7465 7470 +5
Partials 0 0
|
4 tasks
sinhrks
reviewed
Oct 20, 2016
| @@ -270,7 +270,7 @@ def to_datetime(arg, errors='raise', dayfirst=False, yearfirst=False, | |||
| If a date that does not meet timestamp limitations, passing errors='coerce' | |||
| will force to NaT. Furthermore this will force non-dates to NaT as well. | |||
|
|
|||
| >>> pd.to_datetime('13000101', format='%Y%m%d') | |||
| >>> pd.to_datetime('13000101', format='%Y%m%d', errors='ignore') | |||
There was a problem hiding this comment.
it's nice to add an example of default behavior, and describe what the timestamp limitation is.
There was a problem hiding this comment.
@sinhrks sure.
There was a problem hiding this comment.
makes sense - I'll do that!
|
|
@sinhrks Can this be merged? |
|
@jreback Can this be merged? Please let me know if there are any changes to be added. |
jreback
reviewed
Oct 24, 2016
| @@ -267,10 +268,15 @@ def to_datetime(arg, errors='raise', dayfirst=False, yearfirst=False, | |||
| 1 2016-03-05 | |||
| dtype: datetime64[ns] | |||
|
|
|||
| If a date that does not meet timestamp limitations, passing errors='coerce' | |||
| will force to NaT. Furthermore this will force non-dates to NaT as well. | |||
| Since pandas represents timestamps in nanosecond resolution, the timespan | |||
There was a problem hiding this comment.
This sentence is not a complete explanation; instead you can simply refer to a link in the docs about min/max values that are supported.
There was a problem hiding this comment.
|
thanks! |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Nov 2, 2016
…for out-of-bounds timestamps with errors='ignore' closes pandas-dev#14448 Author: Keshav Ramaswamy <[email protected]> Author: Keshav Ramaswamy <[email protected]> Closes pandas-dev#14452 from keshavramaswamy/master and squashes the following commits: 5468fc5 [Keshav Ramaswamy] added link to timestamp limitations in docstring 3aa78cf [Keshav Ramaswamy] edit docstring to fit python standards 8bfa58e [Keshav Ramaswamy] edited docstring to fit python standards 5ed8ef5 [Keshav Ramaswamy] edut docstring to fit Python Standards 7402de4 [Keshav Ramaswamy] edited docstring to fit python standards c16ad6b [Keshav Ramaswamy] added timestamp limitations and default behavior to docstring 0db07b5 [Keshav Ramaswamy] updated docstring in .to_datetime() (cherry picked from commit 18fba53)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.