BUG: ujson fix sniffing of dtype when decoding #1445
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ujson was never auto-sniffing the dtype because
PyArray_DescrConverterconvertsNoneto the numpy default dtype. It should instead usePyArray_DescrConverter2which convertsNonetoNULL.The rest of the changes are to fix tests related to this "new" behaviour.
Tested with Python 2.7 on 64 bit OSX, 32 bit Ubuntu and 32 bit WinXP with Mingw32 and MSVC. EPD is still seg faulting.