-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
ENH: support kind and na_position kwargs in Series.sort_index #14445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jorisvandenbossche
merged 6 commits into
pandas-dev:master
from
brandonmburroughs:series_sort_index
Dec 4, 2016
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
d1d6513
BUG Series.sort_index does not accept parameters kind and na_position
brandonmburroughs aae1c1c
Moving ensure and take
brandonmburroughs 43dd994
Adding na_position for multiindex
brandonmburroughs b013103
Moving to 0.20.0
brandonmburroughs 423c771
Adding note that na_position doesn't work for MultiIndex
brandonmburroughs 05e9e52
Removing na_position argument
brandonmburroughs File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -144,3 +144,28 @@ def test_sort_index_multiindex(self): | |
# rows share same level='A': sort has no effect without remaining lvls | ||
res = s.sort_index(level='A', sort_remaining=False) | ||
assert_series_equal(s, res) | ||
|
||
def test_sort_index_kind(self): | ||
# GH #14444 & #13589: Add support for sort algo choosing | ||
series = Series(index=[3, 2, 1, 4, 3]) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. add a comment with the github reference There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Added |
||
expected_series = Series(index=[1, 2, 3, 3, 4]) | ||
|
||
index_sorted_series = series.sort_index(kind='mergesort') | ||
assert_series_equal(expected_series, index_sorted_series) | ||
|
||
index_sorted_series = series.sort_index(kind='quicksort') | ||
assert_series_equal(expected_series, index_sorted_series) | ||
|
||
index_sorted_series = series.sort_index(kind='heapsort') | ||
assert_series_equal(expected_series, index_sorted_series) | ||
|
||
def test_sort_index_na_position(self): | ||
series = Series(index=[3, 2, 1, 4, 3, np.nan]) | ||
|
||
expected_series_first = Series(index=[np.nan, 1, 2, 3, 3, 4]) | ||
index_sorted_series = series.sort_index(na_position='first') | ||
assert_series_equal(expected_series_first, index_sorted_series) | ||
|
||
expected_series_last = Series(index=[1, 2, 3, 3, 4, np.nan]) | ||
index_sorted_series = series.sort_index(na_position='last') | ||
assert_series_equal(expected_series_last, index_sorted_series) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you put:
outside the if-else block
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes; moved.