TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit #14347

MattRijk · 2016-10-05T00:01:22Z

closes TST: failing test at tseries/tests/test_base.py TestDatetimeIndexOps test_nat #14345
Changed tm.assert_numpy_array_equal(idx._nan_idxs, np.array([], dtype=np.int64)
np.int64 to npintp
All tests now pass on 32bit linux install.

jreback · 2016-10-05T00:13:29Z

pandas/tseries/tests/test_base.py

-        tm.assert_numpy_array_equal(idx._nan_idxs,
-                                    np.array([1], dtype=np.int64))
+    # def test_nat(self):
+    #     self.assertIs(pd.TimedeltaIndex._na_value, pd.NaT)


what the heck are you commenting out a test?

if it's incorrect it should be deleted (but it's not)
it can be skipped on paticular platforms if needed
but this should work on 32bit

jreback · 2016-10-05T00:16:02Z

pandas/tseries/tests/test_base.py

            idx = pd.DatetimeIndex(['2011-01-01', '2011-01-02'], tz=tz)
            self.assertTrue(idx._can_hold_na)

            tm.assert_numpy_array_equal(idx._isnan, np.array([False, False]))
            self.assertFalse(idx.hasnans)
-            tm.assert_numpy_array_equal(idx._nan_idxs,
-                                        np.array([], dtype=np.int64))
+


pls don't change the formatting unless it's germane (this line is too long anyhow)

jreback · 2016-10-05T00:16:22Z

pandas/tseries/tests/test_base.py

-        self.assertIs(pd.PeriodIndex([], freq='M')._na_value, pd.NaT)
-
-        idx = pd.PeriodIndex(['2011-01-01', '2011-01-02'], freq='D')
-        self.assertTrue(idx._can_hold_na)


Sorry about that forgot i commented those out when i was figuring out the error.
I installed pandas on 32bit ubuntu, ran all the nosetests and keep getting that AssertionError.
Should i change it to intp or leave it?

the intp is correct

jreback · 2016-10-05T11:44:12Z

pandas/tseries/tests/test_base.py

@@ -857,25 +857,26 @@ def test_shift(self):
            tm.assert_index_equal(idx.shift(-3, freq='H'), exp)

    def test_nat(self):
-        self.assertIs(pd.DatetimeIndex._na_value, pd.NaT)
+        self.assertIs(pd.DatetimeIndex._na_value, pd.NaT) 


pls revert whitespace changes.

jreback · 2016-10-05T11:44:19Z

pandas/tseries/tests/test_base.py

        self.assertIs(pd.DatetimeIndex([])._na_value, pd.NaT)

        for tz in [None, 'US/Eastern', 'UTC']:
            idx = pd.DatetimeIndex(['2011-01-01', '2011-01-02'], tz=tz)
            self.assertTrue(idx._can_hold_na)
-
+                    


jreback · 2016-10-05T11:44:34Z

pandas/tseries/tests/test_base.py

-            tm.assert_numpy_array_equal(idx._nan_idxs,
-                                        np.array([], dtype=np.int64))
-
+            tm.assert_numpy_array_equal(idx._nan_idxs, 


you seem to be adding whitespace at the end of the line

jreback · 2016-10-05T11:44:52Z

pandas/tseries/tests/test_base.py

@@ -1710,22 +1711,22 @@ def test_repeat(self):
    def test_nat(self):
        self.assertIs(pd.TimedeltaIndex._na_value, pd.NaT)
        self.assertIs(pd.TimedeltaIndex([])._na_value, pd.NaT)
-
+    


same (and below)

I'm getting this error from travis ci - The command "ci/lint.sh" exited with 1. How would I figure this out?

@MattRijk If you look at the log of the failing travis build, at the bottom you will see the output of the linter:

pandas/tseries/tests/test_base.py:860:58: W291 trailing whitespace pandas/tseries/tests/test_base.py:862:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:866:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:869:55: W291 trailing whitespace pandas/tseries/tests/test_base.py:871:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:877:55: W291 trailing whitespace pandas/tseries/tests/test_base.py:1713:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:1716:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:1721:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:1724:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:2710:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:2713:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:2718:1: W293 blank line contains whitespace pandas/tseries/tests/test_base.py:2721:1: W293 blank line contains whitespace

You can normally set your editor to automatically remove trailing white space, then you would normally have less of such issues.

codecov-io · 2016-10-05T13:23:23Z

Current coverage is 85.26% (diff: 100%)

Merging #14347 into master will increase coverage by <.01%

@@             master     #14347   diff @@
==========================================
  Files           140        140          
  Lines         50632      50632          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits          43170      43171     +1   
+ Misses         7462       7461     -1   
  Partials          0          0

Powered by Codecov. Last update 96b364a...73ad3d7

jreback · 2016-10-06T10:22:06Z

thanks @MattRijk lgtm.

…rors on 32-bit closes pandas-dev#14345 Author: mattrijk <[email protected]> Closes pandas-dev#14347 from MattRijk/issue#14345 and squashes the following commits: 73ad3d7 [mattrijk] line 2710 formatting update for whitespace ea4f151 [mattrijk] second formatting update for whitespace 262492f [mattrijk] TST: pandas-dev#14345 fixes TestDatetimeIndexOps test_nat AssertionErors

TST: pandas-dev#14345 fixes TestDatetimeIndexOps test_nat AssertionErors

262492f

jreback requested changes Oct 5, 2016

View reviewed changes

jorisvandenbossche added the Testing pandas testing functions or related to the test suite label Oct 5, 2016

jreback reviewed Oct 5, 2016

View reviewed changes

jreback changed the title ~~TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErors~~ TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit Oct 5, 2016

second formatting update for whitespace

ea4f151

MattRijk force-pushed the issue#14345 branch from e59039d to ea4f151 Compare October 5, 2016 17:57

line 2710 formatting update for whitespace

73ad3d7

jreback approved these changes Oct 6, 2016

View reviewed changes

jreback added this to the 0.19.1 milestone Oct 6, 2016

jreback closed this in 58542e8 Oct 6, 2016

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit #14347

TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit #14347

MattRijk commented Oct 5, 2016 •

edited

Loading

jreback Oct 5, 2016

jreback Oct 5, 2016 •

edited

Loading

jreback Oct 5, 2016

jreback Oct 5, 2016

MattRijk Oct 5, 2016

jreback Oct 5, 2016

jreback Oct 5, 2016

jreback Oct 5, 2016

jreback Oct 5, 2016

jreback Oct 5, 2016

MattRijk Oct 5, 2016

jorisvandenbossche Oct 5, 2016

codecov-io commented Oct 5, 2016 •

edited

Loading

jreback commented Oct 6, 2016

TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit #14347

TST: #14345 fixes TestDatetimeIndexOps test_nat AssertionErrors on 32-bit #14347

Conversation

MattRijk commented Oct 5, 2016 • edited Loading

Choose a reason for hiding this comment

jreback Oct 5, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

codecov-io commented Oct 5, 2016 • edited Loading

Current coverage is 85.26% (diff: 100%)

jreback commented Oct 6, 2016

MattRijk commented Oct 5, 2016 •

edited

Loading

jreback Oct 5, 2016 •

edited

Loading

codecov-io commented Oct 5, 2016 •

edited

Loading