BUG: mixed freq timeseries plotting with shared axes (GH13341) #14330
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jorisvandenbossche
force-pushed
the
timeseries-plotting2
branch
from
18d6d61 to
b3537e2
Compare
Current coverage is 85.26% (diff: 93.75%)
|
TomAugspurger
approved these changes
Oct 3, 2016
| @@ -1584,3 +1584,5 @@ Bug Fixes | |||
| - ``PeridIndex`` can now accept ``list`` and ``array`` which contains ``pd.NaT`` (:issue:`13430`) | |||
| - Bug in ``df.groupby`` where ``.median()`` returns arbitrary values if grouped dataframe contains empty bins (:issue:`13629`) | |||
| - Bug in ``Index.copy()`` where ``name`` parameter was ignored (:issue:`14302`) | |||
| - Bug in plotting regular and irregular timeseries using shared axes | |||
There was a problem hiding this comment.
Will need to move to 0.19.1 now; Sorry I missed this earlier.
| @@ -778,6 +778,42 @@ def test_mixed_freq_irreg_period(self): | |||
| irreg.plot() | |||
| ps.plot() | |||
|
|
|||
| def test_mixed_freq_shared_ax(self): | |||
| import matplotlib.pyplot as plt | |||
There was a problem hiding this comment.
This matches the other tests, but plt should be available on self here, e.g. self.plt.
jorisvandenbossche
force-pushed
the
timeseries-plotting2
branch
from
b3537e2 to
98df6e3
Compare
|
Rebased, moved to 0.19.2 and addressed Tom's comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #13341, partly closes #14322 (that example still does not work when first plotting the irregular series)
cc @sinhrks @TomAugspurger