BUG: date slicing with reverse sorted index #14317
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-b1
changed the title
shoyer
reviewed
Sep 29, 2016
| @@ -1447,7 +1447,11 @@ def _maybe_cast_slice_bound(self, label, side, kind): | |||
| getattr(self, 'inferred_freq', None)) | |||
| _, parsed, reso = parse_time_string(label, freq) | |||
| bounds = self._parsed_string_to_bounds(reso, parsed) | |||
| return bounds[0 if side == 'left' else 1] | |||
| bounds_side = 0 if side == 'left' else 1 | |||
There was a problem hiding this comment.
This isn't really clearer, but it does save a few lines:
bounds_side = int((side == 'left') != self.is_monotonic_decreasing)There was a problem hiding this comment.
@shoyer - I ended up writing this a bit differently, unpacking bounds into 2 names. Let me know if you think it could be any clearer.
Current coverage is 85.26% (diff: 100%)@@ master #14317 diff @@
==========================================
Files 140 140
Lines 50619 50621 +2
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43161 43163 +2
Misses 7458 7458
Partials 0 0
|
jreback
reviewed
Sep 29, 2016
| return bounds[0 if side == 'left' else 1] | ||
| bounds_side = 0 if side == 'left' else 1 | ||
| if self.is_monotonic_decreasing: | ||
| # swap edges |
There was a problem hiding this comment.
would add a comment n why you are doing this
|
lgtm. minor comment. merge when ready. |
jorisvandenbossche
approved these changes
Sep 29, 2016
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffcc @shoyer - good diagnosis!